Fix PREfast Warning C26495, and excluded the generated file path for prefast task (#5556)

* fix MRTBuild warnings

* fix in dev and test

* change excludedPath for prefast task for x64

* use ZeroMemory replace memset; use  replace __t

---------

Co-authored-by: Qiutong Shen <qiutongshen@microsoft.com>

Author: qiutongMS

build/AzurePipelinesTemplates/WindowsAppSDK-BuildFoundation-Steps.yml

@@ -84,7 +84,7 @@ steps:
       msBuildCommandline: 'msbuild.exe /restore /nologo /nr:false /p:configuration=Release /p:platform=x64 $(Build.SourcesDirectory)\WindowsAppRuntime.sln'
       # Generally speaking, we leave it to the external repos to scan the bits in their packages.
       excludedPaths: |
-        $(Build.SourcesDirectory)\packages
+        $(Agent.ToolsDirectory)\uCRT\#$(Build.SourcesDirectory)\obj\$(buildConfiguration)\$(buildPlatform)#$(Build.SourcesDirectory)\packages
     env:
       SYSTEM_ACCESSTOKEN: $(System.AccessToken)
     continueOnError: true

dev/BackgroundTask/BackgroundTaskBuilder/BackgroundTaskBuilder.h

@@ -10,7 +10,7 @@ namespace winrt::Microsoft::Windows::ApplicationModel::Background::implementatio
 {
     struct BackgroundTaskBuilder : BackgroundTaskBuilderT<BackgroundTaskBuilder>
     {
-        BackgroundTaskBuilder()
+        BackgroundTaskBuilder(): m_taskEntryPointClsid{}
         {
             THROW_HR_IF(E_NOTIMPL, !::Microsoft::Windows::ApplicationModel::Background::Feature_BackgroundTask::IsEnabled());
         }

dev/Detours/disasm.cpp

@@ -334,6 +334,10 @@ CDetourDis::CDetourDis(_Out_opt_ PBYTE *ppbTarget, _Out_opt_ LONG *plExtra)
     m_bF3 = FALSE;
     m_bVex = FALSE;
     m_bEvex = FALSE;
+    m_nSegmentOverride = 0;
+    m_lScratchExtra = 0;
+    m_pbScratchTarget = nullptr;
+    ZeroMemory(m_rbScratchDst, sizeof(m_rbScratchDst));
 
     m_ppbTarget = ppbTarget ? ppbTarget : &m_pbScratchTarget;
     m_plExtra = plExtra ? plExtra : &m_lScratchExtra;
@@ -3562,6 +3566,7 @@ CDetourDis::CDetourDis()
     m_pbTarget = (PBYTE)DETOUR_INSTRUCTION_TARGET_NONE;
     m_pbPool = NULL;
     m_lExtra = 0;
+    ZeroMemory(m_rbScratchDst, sizeof(m_rbScratchDst));
 }
 
 PBYTE CDetourDis::CopyInstruction(PBYTE pDst,
@@ -3965,6 +3970,7 @@ BYTE CDetourDis::PureCopy32(BYTE* pSource, BYTE* pDest)
 CDetourDis::CDetourDis()
 {
     m_pbTarget = (PBYTE)DETOUR_INSTRUCTION_TARGET_NONE;
+    ZeroMemory(m_rbScratchDst, sizeof(m_rbScratchDst));
 }
 
 PBYTE CDetourDis::CopyInstruction(PBYTE pDst,

dev/Detours/image.cpp

@@ -775,8 +775,25 @@ CImage::CImage()
     m_hMap = NULL;
     m_pMap = NULL;
 
+    m_nNextFileAddr = 0;
+    m_nNextVirtAddr = 0;
+
+    ZeroMemory(&m_DosHeader, sizeof(m_DosHeader));
+    ZeroMemory(&m_NtHeader, sizeof(m_NtHeader));
+    ZeroMemory(&m_SectionHeaders, sizeof(m_SectionHeaders));
+
+    m_nPrePE = 0;
+    m_cbPrePE = 0;
+    m_cbPostPE = 0;
+
     m_nPeOffset = 0;
     m_nSectionsOffset = 0;
+    m_nExtraOffset = 0;
+    m_nFileSize = 0;
+
+    m_nOutputVirtAddr = 0;
+    m_nOutputVirtSize = 0;
+    m_nOutputFileAddr = 0;
 
     m_pbOutputBuffer = NULL;
     m_cbOutputBuffer = 0;

dev/MRTCore/mrt/mrm/UnitTests/StringResult.UnitTests.cpp

@@ -42,6 +42,7 @@ struct StringResult_Struct
 
     StringResult_Struct()
     {
+        origRef = nullptr;
         shortStr = L"Bye!";
         medStr = L"Hello!";
         concatStr = L" What's Up?";

dev/MRTCore/mrt/mrm/UnitTests/TestFileUtils.cpp

@@ -15,7 +15,9 @@ namespace UnitTests
 {
 
 FileBasedTest::FileBasedTest() : m_runFrom(Current), m_pTestClassName(nullptr), m_pTestMethodName(nullptr), m_pClassDataSubfolder(nullptr)
-{}
+{
+    m_originalDir[0] = L'\0';
+}
 
 DWORD
 FileBasedTest::CreateDirectoryHierarchy(_In_ const WEX::Common::String& path)

dev/MRTCore/mrt/mrm/UnitTests/TestReverseMap.cpp

@@ -15,7 +15,7 @@ using namespace WEX::Logging;
 namespace UnitTests
 {
 
-TestReverseFileMap::TestReverseFileMap() : m_build(), m_pPriBuilder(NULL), m_pReverseFileMapBuilder(NULL), m_pReverseFileMap(NULL) {}
+TestReverseFileMap::TestReverseFileMap() : m_build(), m_pPriBuilder(NULL), m_pReverseFileMapBuilder(NULL), m_pReverseFileMap(NULL), m_pTestDI(nullptr), m_testDI(), m_pDecisionInfo(nullptr) {}
 
 HRESULT
 TestReverseFileMap::InitFromTestVars(__in PriSectionBuilder* pPriBuilder, __in UnifiedEnvironment* pEnvironment, __in PCWSTR pVarPrefix)

dev/MRTCore/mrt/mrm/UnitTests/testEnvironment.cpp

@@ -405,7 +405,7 @@ TestEnvironment::GetQualifierInfo(_In_ INT32 evIndex, _Outptr_ const QUALIFIER_I
     return E_NOTIMPL;
 }
 
-TestEnvironmentCollection::TestEnvironmentCollection() {}
+TestEnvironmentCollection::TestEnvironmentCollection() : m_pEnvironments(nullptr) {}
 
 TestEnvironmentCollection::~TestEnvironmentCollection() { delete m_pEnvironments; }
 

dev/MRTCore/mrt/mrm/UnitTests/testMap.cpp

@@ -21,9 +21,12 @@ TestResourceMap::TestResourceMap() :
     m_build(),
     m_pPriBuilder(nullptr),
     m_pMapBuilder(nullptr),
+    m_pSchemaBuilder(nullptr),
     m_pMap(nullptr),
+    m_pTestDI(nullptr),
     m_pMyMapBuilder(nullptr),
     m_pMySchemaBuilder(nullptr),
+    m_testDI(),
     m_pBaselinePri(nullptr),
     m_expectedFinalizeResult(0),
     m_expectedFinalizeReturn(true),

dev/MRTCore/mrt/mrm/UnitTests/testPri.cpp

@@ -25,6 +25,9 @@ TestHPri::TestHPri() :
     m_buffer(nullptr),
     m_bufferSizeInBytes(0),
     m_pri(nullptr),
+    m_testDI(),
+    m_testEnvironment(nullptr),
+    m_qualifierMappingBuilder(nullptr),
     m_baselinePri(nullptr),
     m_expectedFinalizeResult(0),
     m_expectedFinalizeReturn(true),