Use quotes around default GVFS.Hooks.exe configuration #1838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default install location on Windows is in
C:\Program Files\VFS for Git
. When configuring the hook for GVFS.Hooks.exe the absolute path is recorded in pre-command.hooks and post-command.hooks.GitHooksLoader.exe will read that line verbatim and try to execute it using CreateProcess. This typically works, but it checks for executable files at "C:\Program", "C:\Program.exe", "C:\Program Files\VFS", "C:\Program Files\VFS.exe" etc before resolving to the correct executable.
If a user has a file at C:\Program, then the pre-command hook will try to run it instead, typically failing and blocking all git/gvfs operations.
This pull request puts quotes around the absolute path of GVFS.Hooks.exe when configuring the pre/post command hooks, so that CreateProcess will resolve immediately to the correct executable instead of checking partial paths.