-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Move DOM.Iterable contents to DOM, make DOM reference ES6/ES2015 #62111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@typescript-bot test it |
Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build and an npm module you can use via |
Hey @jakebailey, the results of running the DT tests are ready. There were interesting changes: Branch only errors:Package: es6-collections
Package: es6-shim
|
@jakebailey Here are the results of running the user tests with tsc comparing Everything looks good! |
@jakebailey Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
@jakebailey Here are the results of running the top 400 repos with tsc comparing Something interesting changed - please have a look. Details
|
Related #62025
Related #54500
This should actually happen in the DOM generator repo, but testing here first with a manual change.
A negative side effect of this is that the default lib (only used when there's no lib or target set) used to reference ES5/DOM, but now DOM requires ES6, so basically the default changes. This would be fine if we simply declared that the default lib weas now ES6, which I think we want to do anyway.