Skip to content

Fix JSDoc @import crashes in getCompletionEntryDetails #62028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix JSDoc @import crashes in getCompletionEntryDetails #62028

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fc84df
Initial plan
Copilot Jul 9, 2025
999fdc8
Fix JSDoc @import crashes in getCompletionEntryDetails
Copilot Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/services/codefixes/importFixes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1834,7 +1834,10 @@ function promoteFromTypeOnly(
}

function promoteImportClause(importClause: ImportClause) {
changes.delete(sourceFile, getTypeKeywordOfTypeOnlyImport(importClause, sourceFile));
// JSDoc imports are inherently type-only and don't have a removable 'type' keyword
if (!isJSDocImportTag(importClause.parent)) {
changes.delete(sourceFile, getTypeKeywordOfTypeOnlyImport(importClause, sourceFile));
}
// Change .ts extension to .js if necessary
if (!compilerOptions.allowImportingTsExtensions) {
const moduleSpecifier = tryGetModuleSpecifierFromDeclaration(importClause.parent);
Expand Down