Skip to content

Fix incorrect type declarations for constants inside namespaces merged with enums #61946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/compiler/checker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50962,9 +50962,9 @@
return false;
}

function literalTypeToNode(type: FreshableType, enclosing: Node, tracker: SymbolTracker): Expression {
const enumResult = type.flags & TypeFlags.EnumLike ? nodeBuilder.symbolToExpression(type.symbol, SymbolFlags.Value, enclosing, /*flags*/ undefined, /*internalFlags*/ undefined, tracker)
: type === trueType ? factory.createTrue() : type === falseType && factory.createFalse();
function literalTypeToNode(type: FreshableType, enclosing: Node, tracker: SymbolTracker): Expression {
const enumResult = type.flags & TypeFlags.EnumLike ? nodeBuilder.symbolToExpression(type.symbol, SymbolFlags.Value, /*enclosing*/ undefined, NodeBuilderFlags.UseFullyQualifiedType, /*internalFlags*/ undefined, tracker)

Check failure on line 50966 in src/compiler/checker.ts

View workflow job for this annotation

GitHub Actions / lint

Argument name "enclosing" does not match expected name "enclosingDeclaration"
: type === trueType ? factory.createTrue() : type === falseType && factory.createFalse();
if (enumResult) return enumResult;
const literalValue = (type as LiteralType).value;
return typeof literalValue === "object" ? factory.createBigIntLiteral(literalValue) :
Expand Down
59 changes: 59 additions & 0 deletions tests/baselines/reference/enumNamespaceConstantsDeclaration.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
//// [tests/cases/compiler/enumNamespaceConstantsDeclaration.ts] ////

//// [enumNamespaceConstantsDeclaration.ts]
// Test for constant declarations inside namespace merged with enum
enum Foo {
bar
}
namespace Foo {
export const baz = Foo.bar;
}

// Multiple enum members
enum MyEnum {
First = 1,
Second = 2
}
namespace MyEnum {
export const value1 = MyEnum.First;
export const value2 = MyEnum.Second;
}



//// [enumNamespaceConstantsDeclaration.js]
// Test for constant declarations inside namespace merged with enum
var Foo;
(function (Foo) {
Foo[Foo["bar"] = 0] = "bar";
})(Foo || (Foo = {}));
(function (Foo) {
Foo.baz = Foo.bar;
})(Foo || (Foo = {}));
// Multiple enum members
var MyEnum;
(function (MyEnum) {
MyEnum[MyEnum["First"] = 1] = "First";
MyEnum[MyEnum["Second"] = 2] = "Second";
})(MyEnum || (MyEnum = {}));
(function (MyEnum) {
MyEnum.value1 = MyEnum.First;
MyEnum.value2 = MyEnum.Second;
})(MyEnum || (MyEnum = {}));


//// [enumNamespaceConstantsDeclaration.d.ts]
declare enum Foo {
bar = 0
}
declare namespace Foo {
const baz = Foo.bar;
}
declare enum MyEnum {
First = 1,
Second = 2
}
declare namespace MyEnum {
const value1 = MyEnum.First;
const value2 = MyEnum.Second;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
//// [tests/cases/compiler/enumNamespaceConstantsDeclaration.ts] ////

=== enumNamespaceConstantsDeclaration.ts ===
// Test for constant declarations inside namespace merged with enum
enum Foo {
>Foo : Symbol(Foo, Decl(enumNamespaceConstantsDeclaration.ts, 0, 0), Decl(enumNamespaceConstantsDeclaration.ts, 3, 1))

bar
>bar : Symbol(Foo.bar, Decl(enumNamespaceConstantsDeclaration.ts, 1, 10))
}
namespace Foo {
>Foo : Symbol(Foo, Decl(enumNamespaceConstantsDeclaration.ts, 0, 0), Decl(enumNamespaceConstantsDeclaration.ts, 3, 1))

export const baz = Foo.bar;
>baz : Symbol(baz, Decl(enumNamespaceConstantsDeclaration.ts, 5, 16))
>Foo.bar : Symbol(bar, Decl(enumNamespaceConstantsDeclaration.ts, 1, 10))
>Foo : Symbol(Foo, Decl(enumNamespaceConstantsDeclaration.ts, 0, 0), Decl(enumNamespaceConstantsDeclaration.ts, 3, 1))
>bar : Symbol(bar, Decl(enumNamespaceConstantsDeclaration.ts, 1, 10))
}

// Multiple enum members
enum MyEnum {
>MyEnum : Symbol(MyEnum, Decl(enumNamespaceConstantsDeclaration.ts, 6, 1), Decl(enumNamespaceConstantsDeclaration.ts, 12, 1))

First = 1,
>First : Symbol(MyEnum.First, Decl(enumNamespaceConstantsDeclaration.ts, 9, 13))

Second = 2
>Second : Symbol(MyEnum.Second, Decl(enumNamespaceConstantsDeclaration.ts, 10, 14))
}
namespace MyEnum {
>MyEnum : Symbol(MyEnum, Decl(enumNamespaceConstantsDeclaration.ts, 6, 1), Decl(enumNamespaceConstantsDeclaration.ts, 12, 1))

export const value1 = MyEnum.First;
>value1 : Symbol(value1, Decl(enumNamespaceConstantsDeclaration.ts, 14, 16))
>MyEnum.First : Symbol(First, Decl(enumNamespaceConstantsDeclaration.ts, 9, 13))
>MyEnum : Symbol(MyEnum, Decl(enumNamespaceConstantsDeclaration.ts, 6, 1), Decl(enumNamespaceConstantsDeclaration.ts, 12, 1))
>First : Symbol(First, Decl(enumNamespaceConstantsDeclaration.ts, 9, 13))

export const value2 = MyEnum.Second;
>value2 : Symbol(value2, Decl(enumNamespaceConstantsDeclaration.ts, 15, 16))
>MyEnum.Second : Symbol(Second, Decl(enumNamespaceConstantsDeclaration.ts, 10, 14))
>MyEnum : Symbol(MyEnum, Decl(enumNamespaceConstantsDeclaration.ts, 6, 1), Decl(enumNamespaceConstantsDeclaration.ts, 12, 1))
>Second : Symbol(Second, Decl(enumNamespaceConstantsDeclaration.ts, 10, 14))
}


70 changes: 70 additions & 0 deletions tests/baselines/reference/enumNamespaceConstantsDeclaration.types
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
//// [tests/cases/compiler/enumNamespaceConstantsDeclaration.ts] ////

=== enumNamespaceConstantsDeclaration.ts ===
// Test for constant declarations inside namespace merged with enum
enum Foo {
>Foo : Foo
> : ^^^

bar
>bar : Foo.bar
> : ^^^^^^^
}
namespace Foo {
>Foo : typeof Foo
> : ^^^^^^^^^^

export const baz = Foo.bar;
>baz : Foo.bar
> : ^^^^^^^
>Foo.bar : Foo
> : ^^^
>Foo : typeof Foo
> : ^^^^^^^^^^
>bar : Foo
> : ^^^
}

// Multiple enum members
enum MyEnum {
>MyEnum : MyEnum
> : ^^^^^^

First = 1,
>First : MyEnum.First
> : ^^^^^^^^^^^^
>1 : 1
> : ^

Second = 2
>Second : MyEnum.Second
> : ^^^^^^^^^^^^^
>2 : 2
> : ^
}
namespace MyEnum {
>MyEnum : typeof MyEnum
> : ^^^^^^^^^^^^^

export const value1 = MyEnum.First;
>value1 : MyEnum.First
> : ^^^^^^^^^^^^
>MyEnum.First : MyEnum.First
> : ^^^^^^^^^^^^
>MyEnum : typeof MyEnum
> : ^^^^^^^^^^^^^
>First : MyEnum.First
> : ^^^^^^^^^^^^

export const value2 = MyEnum.Second;
>value2 : MyEnum.Second
> : ^^^^^^^^^^^^^
>MyEnum.Second : MyEnum.Second
> : ^^^^^^^^^^^^^
>MyEnum : typeof MyEnum
> : ^^^^^^^^^^^^^
>Second : MyEnum.Second
> : ^^^^^^^^^^^^^
}


20 changes: 20 additions & 0 deletions tests/cases/compiler/enumNamespaceConstantsDeclaration.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// @declaration: true

// Test for constant declarations inside namespace merged with enum
enum Foo {
bar
}
namespace Foo {
export const baz = Foo.bar;
}

// Multiple enum members
enum MyEnum {
First = 1,
Second = 2
}
namespace MyEnum {
export const value1 = MyEnum.First;
export const value2 = MyEnum.Second;
}

Loading