Skip to content

Iterate inheritance chain when searching for PutForwards #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025

Conversation

saschanaz
Copy link
Contributor

Fixing the failure:

file:///home/runner/work/TypeScript-DOM-lib-generator/TypeScript-DOM-lib-generator/lib/build/emitter.js:627
                    throw new Error("Couldn't find [PutForwards]");
                          ^

Error: Couldn't find [PutForwards]
    at emitProperty (file:///home/runner/work/TypeScript-DOM-lib-generator/TypeScript-DOM-lib-generator/lib/build/emitter.js:627:27)
    at file:///home/runner/work/TypeScript-DOM-lib-generator/TypeScript-DOM-lib-generator/lib/build/emitter.js:677:33
    at Array.forEach (<anonymous>)
    at emitProperties (file:///home/runner/work/TypeScript-DOM-lib-generator/TypeScript-DOM-lib-generator/lib/build/emitter.js:677:18)
    at emitMembers (file:///home/runner/work/TypeScript-DOM-lib-generator/TypeScript-DOM-lib-generator/lib/build/emitter.js:777:9)
    at emitInterface (file:///home/runner/work/TypeScript-DOM-lib-generator/TypeScript-DOM-lib-generator/lib/build/emitter.js:1004:9)
    at emitNonCallbackInterfaces (file:///home/runner/work/TypeScript-DOM-lib-generator/TypeScript-DOM-lib-generator/lib/build/emitter.js:1026:17)
    at emit (file:///home/runner/work/TypeScript-DOM-lib-generator/TypeScript-DOM-lib-generator/lib/build/emitter.js:1113:9)
    at emitWebIdl (file:///home/runner/work/TypeScript-DOM-lib-generator/TypeScript-DOM-lib-generator/lib/build/emitter.js:147:20)
    at emitFlavor (file:///home/runner/work/TypeScript-DOM-lib-generator/TypeScript-DOM-lib-generator/lib/build.js:34:20)

Node.js v22.16.0

Also a cleanup to remove warning.

In general I would also update the lib here, but I'm deferring that because it's huge (the whole WebGPU is coming 🤯)

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@saschanaz
Copy link
Contributor Author

LGTM

@github-actions github-actions bot merged commit 99c5952 into microsoft:main Jun 18, 2025
6 checks passed
Copy link
Contributor

Merging because @saschanaz is a code-owner of all the changes - thanks!

@github-actions github-actions bot deleted the iterate-extends branch June 18, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants