feat: Merging the AVM WAF Changes from feature/avm-waf-aligned into dev #146
+3,044
−8,508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/Modernize-your-code-solution-accelerator into feature/avm-waf-network
…dundancy, and failover
…t/Modernize-your-code-solution-accelerator into feature/avm-waf-network
…t/Modernize-your-code-solution-accelerator into feature/avm-waf-aligned
feat: AI Foundy code private end point working and tested
Abdul-Microsoft
requested review from
Avijit-Microsoft,
Roopan-Microsoft,
Prajwal-Microsoft,
aniaroramsft,
marktayl1 and
Vinay-Microsoft
as code owners
Roopan-Microsoft
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces significant updates to the deployment architecture and configuration, focusing on enabling Azure Well-Architected Framework (WAF)-aligned deployments, improving deployment options, and simplifying infrastructure files. The changes include new documentation, deployment parameters, and the removal of legacy infrastructure scripts.
Deployment Architecture Enhancements:
docs/ArchitectureWAF.mdand include private networking, managed identities, and centralized monitoring.README.mdto describe the sandbox and WAF-aligned deployment options, linking to relevant documentation.Deployment Configuration Improvements:
docs/DeploymentGuide.mdto include detailed steps for selecting between sandbox and WAF-aligned configurations, with guidance on parameter customization and best practices. [1] [2]infra/main.waf-aligned.bicepparamfile for WAF-aligned deployments, with parameters for monitoring, scaling, redundancy, and private networking.Infrastructure Simplification:
infra/deploy_managed_identity.bicep,infra/deploy_keyvault.bicep,infra/deploy_ai_foundry.bicep), consolidating functionality into streamlined deployment scripts. [1] [2] [3]infra/main.bicepparamto align parameter naming conventions with the new architecture.Minor Updates:
azure.yamlconfiguration file by removing the environment block, ensuring consistency with the updated deployment process.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information