fix: quota validation script update #130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several enhancements and fixes across deployment scripts, infrastructure configuration, and documentation. The key changes include improving validation scripts for quota checks, updating default parameters for Azure regions and capacities, and enhancing error handling and output formatting.
Deployment Script Improvements:
Enhanced
validate_model_deployment_quota.ps1
andvalidate_model_deployment_quota.sh
scripts to include discovery of AI Foundry names and validation of existing model deployments before proceeding with quota checks. Improved error handling and output for missing parameters and quota validation results. [1] [2] [3] [4] [5]Updated parameter names in both PowerShell and shell scripts to use consistent camel-case naming conventions for clarity (e.g.,
--SubscriptionId
,--Location
,--ModelsParameter
). [1] [2]Infrastructure Configuration Updates:
Added an output parameter
AZURE_AIFOUNDRY_NAME
ininfra/main.bicep
to expose the AI Foundry name for downstream use.Reduced the default capacity for model deployments from
200
to50
ininfra/main.parameters.json
to optimize resource allocation.Documentation Enhancements:
Updated default Azure region from
japaneast
toeastus2
inCustomizingAzdParameters.md
and added a new parameterAZURE_AISERVICE_LOCATION
for specifying the Azure AI Service location.Enhanced the deployment guide to include additional configurable settings such as model deployment type, model name, and image tag, along with their default values. Improved formatting for better readability.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information