Skip to content

fix: quota validation script update #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025

Conversation

Priyanka-Microsoft
Copy link
Contributor

Purpose

  • ...
    This pull request introduces several enhancements and fixes across deployment scripts, infrastructure configuration, and documentation. The key changes include improving validation scripts for quota checks, updating default parameters for Azure regions and capacities, and enhancing error handling and output formatting.

Deployment Script Improvements:

  • Enhanced validate_model_deployment_quota.ps1 and validate_model_deployment_quota.sh scripts to include discovery of AI Foundry names and validation of existing model deployments before proceeding with quota checks. Improved error handling and output for missing parameters and quota validation results. [1] [2] [3] [4] [5]

  • Updated parameter names in both PowerShell and shell scripts to use consistent camel-case naming conventions for clarity (e.g., --SubscriptionId, --Location, --ModelsParameter). [1] [2]

Infrastructure Configuration Updates:

  • Added an output parameter AZURE_AIFOUNDRY_NAME in infra/main.bicep to expose the AI Foundry name for downstream use.

  • Reduced the default capacity for model deployments from 200 to 50 in infra/main.parameters.json to optimize resource allocation.

Documentation Enhancements:

  • Updated default Azure region from japaneast to eastus2 in CustomizingAzdParameters.md and added a new parameter AZURE_AISERVICE_LOCATION for specifying the Azure AI Service location.

  • Enhanced the deployment guide to include additional configurable settings such as model deployment type, model name, and image tag, along with their default values. Improved formatting for better readability.

Does this introduce a breaking change?

  • Yes
  • [x ] No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 90f97be into dev Jun 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants