Skip to content

feat: implement interactive quota check script with user inputs #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 12, 2025

Conversation

Priyanka-Microsoft
Copy link
Contributor

Purpose

  • ...
    This pull request introduces several changes to improve the validation and deployment of AI models in Azure services. Key updates include enhanced parameter validation, better handling of missing deployments, and improved quota checks across regions. The changes span multiple scripts and configuration files, ensuring more robust and user-friendly workflows.

Enhancements to Parameter Validation and Error Handling:

  • Updated parameter names in scripts/validate_model_deployment_quota.sh and scripts/validate_model_deployment_quota.ps1 for consistency (--subscription--SubscriptionId, --location--Location, --models-parameter--ModelsParameter) and improved error messages for missing or unknown parameters. [1] [2]
  • Added checks for AI Foundry existence and missing deployments in both .sh and .ps1 scripts, skipping quota validation if all required deployments are provisioned. [1] [2]

Improvements to Quota Validation Logic:

  • Enhanced fallback region handling in scripts/validate_model_quota.ps1 to allow user selection of regions with sufficient quota, including a table display of all checked regions. [1] [2]
  • Modified error messages to differentiate between quota validation failures and missing deployments. [1] [2]

Configuration Updates:

  • Changed interactive mode for PowerShell hooks in azure.yaml to true for better user interaction during execution.
  • Added an output variable AZURE_AIFOUNDRY_NAME in infra/main.bicep for easier reference to AI Foundry resources.

Resource Adjustments:

  • Reduced the default capacity for AI model deployments in infra/main.parameters.json from 200 to 50 to optimize resource usage.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 900ba0e into dev Jun 12, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants