Skip to content

fix: prefer user region then all other region #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025

Conversation

Priyanka-Microsoft
Copy link
Contributor

Purpose

  • ...
    This pull request introduces several enhancements to scripts responsible for validating model deployment quotas in Azure. The changes improve error handling, streamline parameter validation, and add checks for existing services and deployments to optimize quota validation. Below is a summary of the most important changes grouped by theme:

Improved Parameter Validation and Error Handling

  • Enhanced validation logic in scripts/validate_model_deployment_quota.ps1 and scripts/validate_model_quota.ps1 to check for missing or invalid parameters and provide clearer error messages. [1] [2]
  • Updated scripts/validate_model_deployment_quota.sh and scripts/validate_model_quota.sh to validate inputs more rigorously, including checks for invalid capacity values and clearer error outputs for unknown options. [1] [2]

Service and Deployment Existence Checks

  • Added logic in scripts/validate_model_deployment_quota.ps1 and scripts/validate_model_deployment_quota.sh to check if the Azure AI service and required model deployments already exist, skipping quota validation if all are provisioned. [1] [2]

Enhanced Quota Validation Logic

  • Updated scripts/validate_model_quota.ps1 to prioritize quota checks in the user-specified region and fallback to other regions if necessary, with detailed output for quota availability.
  • Improved fallback region handling in scripts/validate_model_quota.sh, including better messaging for insufficient quota and clearer instructions for retrying deployment in alternate regions.

Streamlined Code and Output Formatting

  • Refactored error handling and output formatting in both PowerShell and Bash scripts to improve readability and provide more user-friendly messages. [1] [2]

These changes collectively enhance the usability, reliability, and efficiency of the quota validation scripts, making them more robust for deployment scenarios in Azure environments.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 7bdb69b into dev Jun 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants