Skip to content

feat: Standardize Bicep Parameters for Code Modernization #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 4, 2025

Conversation

VishalS-Microsoft
Copy link
Contributor

Purpose

This pull request introduces several enhancements and updates across multiple areas, including development environment configuration, test automation, documentation, and infrastructure deployment. The most significant changes involve adding new Azure CLI features to the dev container, creating a new GitHub Actions workflow for test automation, and updating infrastructure templates to include Application Insights integration.

Development Environment Enhancements:

  • Added the Azure CLI feature with Bicep support to the dev container configuration (.devcontainer/devcontainer.json). This includes setting the installBicep option to true and specifying the latest versions for Azure CLI and Bicep.
  • Updated the VS Code extensions list to include ms-azuretools.vscode-azcli for enhanced Azure CLI support.

Test Automation Workflow:

  • Introduced a new GitHub Actions workflow (.github/workflows/test-automation.yml) to automate end-to-end testing. The workflow includes:
    • Scheduled and triggered runs for specific branches and paths.
    • Steps for setting up Python, logging into Azure CLI, starting/stopping container apps, running Playwright tests with retries, and uploading test reports.
    • A notification mechanism to send success or failure emails using a Logic App.

Infrastructure Updates:

  • Modified the Bicep templates (infra/deploy_ai_foundry.bicep, infra/main.bicep) to add Application Insights as a resource for enhanced monitoring. The connection string is exposed as an output for integration with other components. [1] [2]
  • Updated parameter handling in infra/main.bicepparam to include new parameters like deploymentType, llmModel, and imageVersion, with default values fetched from environment variables.

Documentation Updates:

  • Reorganized and expanded the documentation for customizing Azure Dev CLI (azd) parameters, providing a detailed table of parameters and their purposes (docs/CustomizingAzdParameters.md).
  • Corrected typos and updated parameter examples in the customization guide (docs/EXAMPLE-CustomizingAzdParameters.md). [1] [2]

Miscellaneous:

  • Updated the JSON ARM template (infra/main.json) to reflect changes in the Bicep templates, including Application Insights integration and parameter adjustments. [1] [2]

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 0ff6ab4 into dev Jun 4, 2025
6 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the psl-us18810-codmod branch June 4, 2025 11:03
Copy link

github-actions bot commented Jun 5, 2025

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants