fix: To reuse Log Analytics across subscriptions #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vamshi-Microsoft
requested review from
Avijit-Microsoft,
Roopan-Microsoft,
Prajwal-Microsoft,
aniaroramsft,
marktayl1 and
Vinay-Microsoft
as code owners
Prajwal-Microsoft
approved these changes
Jun 4, 2025
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces improvements to the handling of existing Log Analytics Workspace IDs in both documentation and infrastructure code. The changes ensure consistency and correctness when specifying the full resource ID format and enhance the deployment logic to accommodate subscriptions explicitly.
Documentation Updates:
docs/CustomizingAzdParameters.md: Updated the example for setting theAZURE_ENV_LOG_ANALYTICS_WORKSPACE_IDto use the full resource ID format, including subscription, resource group, and workspace name.Infrastructure Code Enhancements:
infra/deploy_ai_foundry.bicep: Added logic to extract the subscription ID (existingLawSubscription) from theexistingLogAnalyticsWorkspaceIdparameter, ensuring proper handling of workspace scope.infra/deploy_ai_foundry.bicep: Modified theexistingLogAnalyticsWorkspaceresource declaration to include the subscription ID in the scope, improving accuracy when referencing existing resources.Does this introduce a breaking change?
Deployment Validation