refactor: standardize naming conventions and parameter handling in Bicep templates1 #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request focuses on standardizing naming conventions and improving parameter handling in the Bicep infrastructure files. The most significant changes involve replacing inconsistent variable names, refining resource prefixes, and ensuring that parameters conform to updated naming and length constraints.
Naming Convention Updates:
prefixCleaned
withResourcePrefix
across multiple resources, ensuring consistency in naming conventions. (infra/main.bicep
: [1] [2] [3] [4] [5] [6] [7]aiServicesName
toazureAiServicesName
for clarity and alignment with Azure naming standards. (infra/main.bicep
: infra/main.bicepL81-R77)Parameter Refinements:
ResourcePrefix
parameter toPrefix
with updated constraints (3-20 characters) and added logic to truncate longer values to 20 characters. (infra/main.bicep
: infra/main.bicepL2-R5)infra/main.bicep
: infra/main.bicepL2-R5)Resource Name Adjustments:
ResourcePrefix
to ensure unique and descriptive names for resources like storage containers, AI services, and container apps. (infra/main.bicep
: [1] [2] [3] [4]Variable Simplifications:
ResourcePrefix
and removing unnecessary transformations likereplace
operations. (infra/main.bicep
: infra/main.bicepL52-R52)aiHubName
and replaced them with updated counterparts (azureAiHubName
). (infra/deploy_ai_foundry.bicep
: infra/deploy_ai_foundry.bicepL14-L30)Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information