Skip to content

chore: restructure infra naming conventions and enhance deployment scripts #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

Harmanpreet-Microsoft
Copy link
Contributor

Purpose

This pull request introduces several changes focused on standardizing resource naming conventions, improving infrastructure deployment scripts, and enhancing configuration management. Key updates include the addition of a .dockerignore file, restructuring of abbreviations in infra/abbreviations.json, and refactoring of multiple Bicep templates to use the new abbreviations and naming conventions.

Configuration and File Management:

  • Added a comprehensive .dockerignore file to exclude unnecessary files and directories from Docker builds, including temporary files, build artifacts, and IDE-specific files.

Abbreviation Standardization:

  • Restructured infra/abbreviations.json to group abbreviations by resource categories (e.g., AI, analytics, compute, etc.) for improved organization and maintainability. This change introduces new abbreviations for various Azure resources.

Bicep Template Refactoring:

  • Updated infra/deploy_ai_foundry.bicep to dynamically load abbreviations from infra/abbreviations.json and apply them to resource names, ensuring consistency across deployments. This includes changes to variables like storageName, aiServicesName, and aiHubName. [1] [2] [3]
  • Improved infra/main.bicep by replacing hardcoded prefixes with dynamically generated ones using abbreviations and unique strings, and cleaned up resource naming logic. [1] [2]

KeyVault Enhancements:

  • Modified infra/deploy_keyvault.bicep to enable soft delete and purge protection for Key Vault resources, enhancing security and compliance.

These changes collectively improve the maintainability, scalability, and security of the infrastructure codebase.

  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@Harmanpreet-Microsoft Harmanpreet-Microsoft changed the base branch from main to dev May 20, 2025 05:46
Harmanpreet Kaur added 2 commits May 20, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant