fix: fixes for the Bug Bash feedback #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abdul-Microsoft
requested review from
Avijit-Microsoft,
Roopan-Microsoft,
Prajwal-Microsoft,
aniaroramsft,
marktayl1 and
Vinay-Microsoft
as code owners
Roopan-Microsoft
approved these changes
May 26, 2025
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces updates to the development environment, parameter naming conventions, and documentation for customizing Azure Developer (azd) parameters. The most significant changes include adding new features to the dev container, renaming parameters in
azure.yaml, and updating documentation for clarity and accuracy.Development Environment Enhancements:
.devcontainer/devcontainer.jsonto include the Azure CLI feature with Bicep support and added thems-azuretools.vscode-azcliextension. ApostCreateCommandwas also added to make thequota_check_params.shscript executable.Parameter Naming Updates:
azure.yamlfor better clarity and alignment:AiLocationwas renamed toAzureAiServiceLocation.ResourcePrefixwas renamed toPrefix.Documentation Improvements:
docs/CustomizingAzdParameters.mdfor setting the Content Understanding Location (AZURE_ENV_CU_LOCATION) with allowed values (Sweden Central,Australia East).docs/EXAMPLE-CustomizingAzdParameters.md("charaters" to "characters") and updated allowed values forAZURE_ENV_MODEL_NAMEto only includegpt-4o. [1] [2]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information