refactor: standardize resource naming and improve Bicep templates with dynamic abbreviations #101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces significant updates to improve resource naming consistency, streamline infrastructure code, and enhance maintainability. The changes include adding a comprehensive
.dockerignore
file, restructuring theabbreviations.json
file for better organization, and updating multiple Bicep templates to use abbreviations for resource names.Infrastructure and Configuration Updates:
.dockerignore
file: Added a detailed.dockerignore
file to exclude unnecessary files and directories from Docker builds, such as temporary files, local build artifacts, and IDE-related files. This improves build efficiency and security.infra/abbreviations.json
file: Restructured and expanded the abbreviations file to organize resource abbreviations into categories likeai
,analytics
,compute
, and more. This enhances readability and scalability for managing resource naming conventions.Bicep Template Enhancements:
Dynamic resource naming: Updated multiple Bicep templates (
deploy_ai_foundry.bicep
,deploy_keyvault.bicep
,deploy_managed_identity.bicep
, andmain.bicep
) to use abbreviations fromabbreviations.json
for resource names. This ensures consistent and concise naming across resources. Examples include:${abbrs.ai.aiServices}${solutionName}
.${abbrs.security.keyVault}${prefixCleaned}
.${abbrs.databases.cosmosDBDatabase}${prefixCleaned}databaseAccount
.Parameter simplification: Removed hardcoded default values for parameters like
keyvaultName
andmiName
indeploy_keyvault.bicep
anddeploy_managed_identity.bicep
, allowing greater flexibility during deployments. [1] [2]Resource property updates: Commented out the
statisticsEnabled
property in the AI services resource definition, likely for future review or adjustments....
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information