Skip to content

Conversation

ASPS002
Copy link
Collaborator

@ASPS002 ASPS002 commented Mar 24, 2025

Description

This Pull request adds a new test configuration disableGifEncoder having default value as false. It disables the collection of screenshots during the test runs by blocking the calls to startGifEncoder and stopGifEncoder methods when the disableGifEncoder is set to true.

Linked GitHub issue ID:

Pull Request Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Code compiles correctly with all tests are passed.
  • I've read the contributing guide and followed the recommended practices.
  • Wikis or README have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

If this introduces a breaking change for Hydra Lab users, please describe the impact and migration path.

  • Yes
  • No

How you tested it

Please make sure the change is tested, you can test it by adding UTs, do local test and share the screenshots, etc.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Technical design
  • Build related changes
  • Refactoring (no functional changes, no api changes)
  • Code style update (formatting, renaming) or Documentation content changes
  • Other (please describe):

Feature UI screenshots or Technical design diagrams

If this is a relatively large or complex change, kick it off by drawing the tech design with PlantUML and explaining why you chose the solution you did and what alternatives you considered, etc...

@zhou9584
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ASPS002 ASPS002 merged commit 35c3027 into main Mar 25, 2025
7 checks passed
@ASPS002 ASPS002 deleted the user/ujsrivastava/add_spec_to_turn_off_gif_collector branch March 25, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants