Add Sora video generation sample #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DETAILS - Updated solution to include "11 Video Generation" and "VideoGeneration-AzureSora-01" projects. - Modified `Program.cs` to implement video generation functionality with Azure's OpenAI service, including configuration loading, job creation, status polling, and video downloading. - Created `VideoGeneration-AzureSora-01.csproj` targeting .NET 9.0 with user secrets management.
|
👋 Thanks for contributing @elbruno! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new Azure OpenAI Sora video generation sample project to the course and updates documentation to surface the new demo.
- Introduces a new
VideoGeneration-AzureSora-01project (net9.0) in the solution, with user secrets and sample code. - Implements end-to-end video generation (job creation, polling, download) in
Program.cs. - Updates
README.mdand10-WhatsNew/readme.mdto highlight the Sora video generation demo.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Added Sora video generation demo to main README |
| 10-WhatsNew/readme.md | Documented June 2025 entry for Sora demo |
| 03-CoreGenerativeAITechniques/src/VideoGeneration-AzureSora-01/VideoGeneration-AzureSora-01.csproj | New project file for the video generation sample |
| 03-CoreGenerativeAITechniques/src/VideoGeneration-AzureSora-01/Program.cs | Implemented Sora video generation workflow |
| 03-CoreGenerativeAITechniques/src/CoreGenerativeAITechniques.sln | Added solution folder and project references |
Comments suppressed due to low confidence (1)
10-WhatsNew/readme.md:9
- [nitpick] The heading omits 'OpenAI' and 'Demo' compared to the main README; consider aligning it to 'Azure OpenAI Sora Video Generation Demo' for consistency.
- **New Lesson 3 Sample: Azure Sora Video Generation**
|
|
||
| string idx = DateTime.Now.ToString("ddMMMyyyy_HHmmss"); | ||
| string suffix = new string(prompt.Length > 30 ? prompt.Substring(0, 30).ToCharArray() : prompt.ToCharArray()); | ||
| suffix = suffix.Replace(",", "_").Replace(".", "_").Replace(" ", "_"); |
There was a problem hiding this comment.
Only replacing commas, periods, and spaces may leave other invalid filename characters. Consider sanitizing suffix using Path.GetInvalidFileNameChars() or a regex to remove all invalid characters.
Suggested change
| suffix = suffix.Replace(",", "_").Replace(".", "_").Replace(" ", "_"); | |
| var invalidChars = Path.GetInvalidFileNameChars(); | |
| suffix = new string(suffix.Select(c => invalidChars.Contains(c) ? '_' : c).ToArray()); |
Copilot uses AI. Check for mistakes.
| do | ||
| { | ||
| await Task.Delay(5000); | ||
| var statusResp = await client.GetAsync(statusUrl); |
There was a problem hiding this comment.
Consider calling statusResp.EnsureSuccessStatusCode() after the GET request to immediately handle HTTP errors rather than parsing potentially invalid JSON.
Suggested change
| var statusResp = await client.GetAsync(statusUrl); | |
| var statusResp = await client.GetAsync(statusUrl); | |
| statusResp.EnsureSuccessStatusCode(); |
Copilot uses AI. Check for mistakes.
Comment on lines
+36
to
+38
| var client = new HttpClient(); | ||
| client.DefaultRequestHeaders.Add("api-key", apiKey); | ||
| client.DefaultRequestHeaders.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json")); |
There was a problem hiding this comment.
Creating a new HttpClient instance per request can lead to socket exhaustion; consider reusing a single HttpClient instance or using IHttpClientFactory.
Suggested change
| var client = new HttpClient(); | |
| client.DefaultRequestHeaders.Add("api-key", apiKey); | |
| client.DefaultRequestHeaders.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json")); | |
| var client = httpClient; // Reuse the top-level HttpClient instance |
Copilot uses AI. Check for mistakes.
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration.UserSecrets" Version="6.0.1" /> |
There was a problem hiding this comment.
[nitpick] The UserSecrets package version 6.0.1 may not align with the project's .NET 9.0 target; consider updating to a version compatible with .NET 9 or relying on built-in secrets support.
Copilot uses AI. Check for mistakes.
Check Broken URLsWe have automatically detected the following broken URLs in your files. Review and fix the paths to resolve this issue. Check the file paths and associated broken URLs inside them.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature for video generation using the Azure OpenAI Sora model and updates relevant documentation and project files. The changes include adding a new lesson sample, implementing the video generation functionality, and updating the course materials to reflect the new capabilities.
New feature: Azure OpenAI Sora Video Generation
Project and functionality updates:
VideoGeneration-AzureSora-01, to the solution fileCoreGenerativeAITechniques.sln. This includes the necessary configurations for building and debugging the video generation demo. [1] [2] [3]Program.cs, which allows users to generate videos from text prompts using the Azure OpenAI Sora model. The implementation includes job creation, polling for status, and downloading the generated video..csprojfile forVideoGeneration-AzureSora-01with configurations for .NET 9.0, user secrets, and necessary dependencies.Documentation updates:
README.mdto highlight the new Azure OpenAI Sora Video Generation demo, including a description of its features and links to the sample code and official documentation.10-WhatsNew/readme.mdto include details about the new Sora video generation demo in Lesson 3, along with instructions and links for further exploration.These changes provide users with a hands-on example of generating videos using text prompts, enhancing the course's generative AI capabilities.