-
Notifications
You must be signed in to change notification settings - Fork 549
Strengthen security practices in FF website #24762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c9e6dc1
Use hashes to validate inline scripts in docs build
dannimad cf58f18
Update tools/pipelines/deploy-website.yml
dannimad 0fdc543
Update docs/validateHashes.sh
dannimad f328478
sanitize html strings with dompurify
dannimad f25224d
Merge branch 'hashes-inline' of https://github.com/microsoft/FluidFra…
dannimad e15fb72
update lock file
dannimad 437ee77
lock file update
dannimad 8067d2d
nit
dannimad c4c038e
nit
dannimad e2cb69a
removing log
dannimad 7aa08ab
exclude dompurify from js file check
dannimad af18e2e
no header skip
dannimad d1ade2a
format
dannimad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
#!/bin/bash | ||
|
||
set -eu -o pipefail | ||
# This script validates the hashes of inline scripts in the index.html file against the configured hashes in the staticwebapp.config.json file. | ||
indexFile="build/index.html" | ||
configFile="static/staticwebapp.config.json" | ||
|
||
echo "Extracting and hashing inline scripts from $indexFile" | ||
|
||
expectedHashes="expected_hashes.txt" | ||
generatedHashes="generated_hashes.txt" | ||
> "$expectedHashes" | ||
> "$generatedHashes" | ||
|
||
# Extract inline scripts and compute hashes | ||
awk 'BEGIN { RS="</script>"; FS="<script[^>]*>" } | ||
NF>1 { print $2 }' "$indexFile" | while read -r scriptContent; do | ||
if [[ "$scriptContent" != "" ]]; then | ||
echo "$scriptContent" | tr -d '\n'| openssl dgst -sha256 -binary | openssl base64 | sed 's/^/sha256-/' >> "$generatedHashes" | ||
fi | ||
done | ||
|
||
echo "Extracted Hashes:" | ||
cat "$generatedHashes" | ||
|
||
echo "Reading configured hashes from $configFile" | ||
grep -oE "sha256-[A-Za-z0-9+/=]{43,45}" "$configFile" | sort | uniq > $expectedHashes | ||
dannimad marked this conversation as resolved.
Show resolved
Hide resolved
|
||
cat $expectedHashes | ||
|
||
echo "Validating..." | ||
fail=0 | ||
while read -r actualHash; do | ||
if ! grep -q "$actualHash" $expectedHashes; then | ||
echo "Missing hash in config: $actualHash" | ||
fail=1 | ||
else | ||
echo "Hash matched: $actualHash" | ||
fi | ||
done < "$generatedHashes" | ||
|
||
rm -f "$generatedHashes" "$expectedHashes" | ||
|
||
if [ "$fail" -ne 0 ]; then | ||
echo "Inline script hashes do not match configured values. Override the hashes in $configFile with the extracted hashes." | ||
exit 1 | ||
fi | ||
|
||
echo "All inline script hashes are valid." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.