refactor(client-presence): rename and move acknowledgment ID type #24753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: framework
There was a problem hiding this comment.
Pull Request Overview
Refactors the acknowledgment ID type in the presence protocol by renaming and relocating its alias.
- Introduces a new
AcknowledgmentIdalias at the top of the file. - Updates references in
DatastoreUpdateMessageandAcknowledgementMessageto useAcknowledgmentId. - Removes the old
AcknowledgmentIdTypealias at the bottom.
Comments suppressed due to low confidence (2)
packages/framework/presence/src/protocol.ts:35
- [nitpick] The alias 'AcknowledgmentId' uses American spelling, but the properties and message names use British spelling ('acknowledgement'). Consider normalizing the spelling to avoid confusion.
type AcknowledgmentId = string;
packages/framework/presence/src/protocol.ts:46
- [nitpick] Inconsistent spelling between the property 'acknowledgementId' (British) and the type alias 'AcknowledgmentId' (American). Align the spelling for clarity and consistency.
acknowledgementId?: AcknowledgmentId;
jason-ha
approved these changes
Jun 2, 2025
MarioJGMsoft
pushed a commit
to MarioJGMsoft/FluidFramework
that referenced
this pull request
Jun 10, 2025
…crosoft#24753) ## Description Addresses nit in microsoft#24470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses nit in #24470