Skip to content

update type tests in release branch #24610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

Conversation

dannimad
Copy link
Contributor

Following release process:

pnpm exec flub typetests -g client --reset --normalize --previous; pnpm install --no-frozen-lockfile; pnpm run build

@Copilot Copilot AI review requested due to automatic review settings May 13, 2025 19:42
@dannimad dannimad requested a review from a team as a code owner May 13, 2025 19:42
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: sharedstring area: dds: tree area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc dependencies Pull requests that update a dependency file base: release PRs targeted against a release branch labels May 13, 2025
Copy link
Contributor

Warning

WARNING: This PR is targeting a release branch!

All changes must first be merged into main and then backported to the target release branch.
Please include a link to the main PR in the description of this PR.

Changes to release branches require approval from the Patch Triage group before merging.
You should have already discussed this change with them so they know to expect it.

For more details, see our internal documentation for the patch policy and processes for
patch releases.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The purpose of this PR is to update the release branch by bumping the version references for several Fluid Framework packages from 2.33.0 to 2.40.0 and to adjust the associated type validation tests.

  • Update package.json dependencies to use version 2.40.0 for the "-previous" packages.
  • Remove several forward/backward compatibility test blocks in generated type validation files.
  • Clear the typeValidation.broken configuration in packages/dds/sequence/package.json.

Reviewed Changes

Copilot reviewed 69 out of 69 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/dds/shared-summary-block/package.json Updated shared-summary-block dependency version.
packages/dds/shared-object-base/package.json Updated shared-object-base dependency version.
packages/dds/sequence/src/test/types/validateSequencePrevious.generated.ts Removed multiple compatibility test blocks.
packages/dds/sequence/package.json Updated sequence-previous version and cleared typeValidation.broken.
packages/dds/register-collection/package.json Updated register-collection dependency version.
packages/dds/ordered-collection/package.json Updated ordered-collection dependency version.
packages/dds/merge-tree/package.json Updated merge-tree dependency version.
packages/dds/matrix/package.json Updated matrix dependency version.
packages/dds/map/package.json Updated map dependency version.
packages/dds/counter/package.json Updated counter dependency version.
packages/dds/cell/package.json Updated cell dependency version.
packages/common/driver-definitions/package.json Updated driver-definitions dependency version.
packages/common/core-utils/package.json Updated core-utils dependency version.
packages/common/core-interfaces/src/test/types/validateCoreInterfacesPrevious.generated.ts Added tests for new compatibility checks.
packages/common/core-interfaces/package.json Updated core-interfaces dependency version.
packages/common/container-definitions/package.json Updated container-definitions dependency version.
packages/common/client-utils/package.json Updated client-utils dependency version.
experimental/dds/attributable-map/package.json Updated attributable-map dependency version.
examples/data-objects/table-tree/package.json Added typeValidation settings to disable validations.
azure/packages/azure-service-utils/package.json Updated azure-service-utils dependency version.
Comments suppressed due to low confidence (2)

packages/dds/sequence/src/test/types/validateSequencePrevious.generated.ts:267

  • The removal of several compatibility test blocks may reduce type validation coverage. Verify that necessary type checks are still in place elsewhere to ensure forward and backward compatibility.
/* Removed compatibility tests block

packages/dds/sequence/package.json:202

  • [nitpick] Clearing the 'broken' configuration in typeValidation could affect compatibility error validations. Ensure that the removal of the specific broken interface markers aligns with the intended release behavior.
"typeValidation": { "broken": {}

@dannimad dannimad enabled auto-merge (squash) May 13, 2025 19:43
@dannimad dannimad merged commit de6ee58 into release/client/2.40 May 15, 2025
37 checks passed
@dannimad dannimad deleted the typetests240-r branch May 15, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: sharedstring area: dds: tree area: dds Issues related to distributed data structures area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: tests Tests to add, test infrastructure improvements, etc base: release PRs targeted against a release branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants