Skip to content

Shared Tree: Persisted Schema Format v2 with persisted metadata support #24590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 40 commits into from
Closed
Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
bd8406a
Initial change.
TommyBrosman May 12, 2025
3165fe3
persistedMetadata is now backed by an object instead of a string.
TommyBrosman May 13, 2025
9709ede
Updated codec.spec.ts to cover FormatV2.
TommyBrosman May 13, 2025
ba058e1
Removed extraneous whitespace change.
TommyBrosman May 13, 2025
b819742
- Changed TreeNodeStoredSchema implementations to take the write vers…
TommyBrosman May 13, 2025
0b5c842
- Changed the stored schema implementation to handle multiple schema …
TommyBrosman May 13, 2025
ecdca7a
Merge branch 'main' into metadata-schema-3
TommyBrosman May 13, 2025
1117c2c
Apply suggestions from code review
TommyBrosman May 14, 2025
94a5c39
- Switched to using the SchemaCodecVersion in public APIs. Eventually…
TommyBrosman May 14, 2025
302cb21
Merge branch 'metadata-schema-3' of https://github.com/TommyBrosman/F…
TommyBrosman May 14, 2025
0ba34d1
- Removed the schema version constant and replaced it with SchemaCode…
TommyBrosman May 14, 2025
3275ee0
Minor: reverted changes to FluidClientVersion utils.
TommyBrosman May 15, 2025
7c48b9d
Switched back to using min client version for importCompressed.
TommyBrosman May 15, 2025
a2f4195
Minor: reverted accidental change.
TommyBrosman May 15, 2025
4786dcc
Apply suggestions from code review
TommyBrosman May 15, 2025
6fa8836
Made persisted metadata schema field naming consistent.
TommyBrosman May 15, 2025
e4064c7
- Created a separate storedSchemaDecodeDispatcher for v2 schemas.
TommyBrosman May 16, 2025
ab1b882
- Refactored the node kind dispatch.
TommyBrosman May 19, 2025
1027daa
Updated snapshots.
TommyBrosman May 19, 2025
e527eba
- Removed minimum client version changes. Equivalent changes will be …
TommyBrosman May 19, 2025
3eae1f6
Removed more minimumClientVersion glue.
TommyBrosman May 19, 2025
98e1b76
Updated API files.
TommyBrosman May 19, 2025
ecc77c9
Rename: SchemaCodecVersion -> SchemaVersion.
TommyBrosman May 20, 2025
37e900f
Merge branch 'main' into metadata-schema-3
TommyBrosman May 20, 2025
737633b
Removed top-level persisted metadata.
TommyBrosman May 21, 2025
4bb136c
Fixed comments.
TommyBrosman May 22, 2025
0bcb90f
Exposed persistedMetadata as a JsonCompatibleReadOnlyObject.
TommyBrosman May 22, 2025
a675338
Changeset.
TommyBrosman May 22, 2025
1d1ef5f
Wired up toStoredSchema. Still needs tests.
TommyBrosman May 22, 2025
b9898e8
- Updated an old snapshot that didn't include the metadata field.
TommyBrosman May 22, 2025
6ca189a
Refactor: persistedMetadata -> metadata on persisted types.
TommyBrosman May 27, 2025
85240dc
Apply suggestions from code review
TommyBrosman May 27, 2025
8883d45
- Updated the changeset description
TommyBrosman May 28, 2025
9c2c13f
Reverted unnecessary change.
TommyBrosman May 28, 2025
c62f7ec
Wired up node schema metadata persistence. Currently errors on tests …
TommyBrosman May 29, 2025
2f6b519
Reverted unneeded change.
TommyBrosman May 29, 2025
ae1779b
Removed tests for the alpha API I removed in a previous revision.
TommyBrosman May 29, 2025
7eff8ab
This revision adds simple-tree persistence for node and field schema …
TommyBrosman May 30, 2025
f3f572c
- Fixed missing persistedMetadata on fields. toStoredSchema.ts and sh…
TommyBrosman Jun 2, 2025
faaf2f7
Merge branch 'main' into metadata-schema-3
TommyBrosman Jun 2, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/brown-dingos-switch.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@fluidframework/tree": minor
"__section": feature
---
Added a v2 Shared Tree schema with support for persisted metadata.

This change adds support for persisted metadata, but does not enable it by default.
10 changes: 10 additions & 0 deletions packages/dds/tree/api-report/tree.alpha.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ export interface FieldSchemaAlphaUnsafe<out Kind extends FieldKind, out Types ex
export interface FieldSchemaMetadata<TCustomMetadata = unknown> {
readonly custom?: TCustomMetadata;
readonly description?: string | undefined;
readonly persistedMetadata?: JsonCompatibleReadOnlyObject | undefined;
}

// @alpha
Expand Down Expand Up @@ -443,6 +444,14 @@ export type JsonCompatibleObject<TExtra = never> = {
[P in string]?: JsonCompatible<TExtra>;
};

// @public
export type JsonCompatibleReadOnly = string | number | boolean | null | readonly JsonCompatibleReadOnly[] | JsonCompatibleReadOnlyObject;

// @public
export type JsonCompatibleReadOnlyObject = {
readonly [P in string]?: JsonCompatibleReadOnly;
};

// @alpha @sealed
export type JsonFieldSchema = {
readonly description?: string | undefined;
Expand Down Expand Up @@ -584,6 +593,7 @@ export enum NodeKind {
export interface NodeSchemaMetadata<out TCustomMetadata = unknown> {
readonly custom?: TCustomMetadata | undefined;
readonly description?: string | undefined;
readonly persistedMetadata?: JsonCompatibleReadOnlyObject | undefined;
}

// @public @sealed
Expand Down
10 changes: 10 additions & 0 deletions packages/dds/tree/api-report/tree.beta.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ export class FieldSchema<out Kind extends FieldKind = FieldKind, out Types exten
export interface FieldSchemaMetadata<TCustomMetadata = unknown> {
readonly custom?: TCustomMetadata;
readonly description?: string | undefined;
readonly persistedMetadata?: JsonCompatibleReadOnlyObject | undefined;
}

// @public @system
Expand Down Expand Up @@ -176,6 +177,14 @@ export interface ITreeViewConfiguration<TSchema extends ImplicitFieldSchema = Im
readonly schema: TSchema;
}

// @public
export type JsonCompatibleReadOnly = string | number | boolean | null | readonly JsonCompatibleReadOnly[] | JsonCompatibleReadOnlyObject;

// @public
export type JsonCompatibleReadOnlyObject = {
readonly [P in string]?: JsonCompatibleReadOnly;
};

// @public
export type LazyItem<Item = unknown> = Item | (() => Item);

Expand Down Expand Up @@ -227,6 +236,7 @@ export enum NodeKind {
export interface NodeSchemaMetadata<out TCustomMetadata = unknown> {
readonly custom?: TCustomMetadata | undefined;
readonly description?: string | undefined;
readonly persistedMetadata?: JsonCompatibleReadOnlyObject | undefined;
}

// @public @sealed
Expand Down
10 changes: 10 additions & 0 deletions packages/dds/tree/api-report/tree.legacy.alpha.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ export class FieldSchema<out Kind extends FieldKind = FieldKind, out Types exten
export interface FieldSchemaMetadata<TCustomMetadata = unknown> {
readonly custom?: TCustomMetadata;
readonly description?: string | undefined;
readonly persistedMetadata?: JsonCompatibleReadOnlyObject | undefined;
}

// @public @system
Expand Down Expand Up @@ -176,6 +177,14 @@ export interface ITreeViewConfiguration<TSchema extends ImplicitFieldSchema = Im
readonly schema: TSchema;
}

// @public
export type JsonCompatibleReadOnly = string | number | boolean | null | readonly JsonCompatibleReadOnly[] | JsonCompatibleReadOnlyObject;

// @public
export type JsonCompatibleReadOnlyObject = {
readonly [P in string]?: JsonCompatibleReadOnly;
};

// @public
export type LazyItem<Item = unknown> = Item | (() => Item);

Expand Down Expand Up @@ -222,6 +231,7 @@ export enum NodeKind {
export interface NodeSchemaMetadata<out TCustomMetadata = unknown> {
readonly custom?: TCustomMetadata | undefined;
readonly description?: string | undefined;
readonly persistedMetadata?: JsonCompatibleReadOnlyObject | undefined;
}

// @public @sealed
Expand Down
10 changes: 10 additions & 0 deletions packages/dds/tree/api-report/tree.legacy.public.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ export class FieldSchema<out Kind extends FieldKind = FieldKind, out Types exten
export interface FieldSchemaMetadata<TCustomMetadata = unknown> {
readonly custom?: TCustomMetadata;
readonly description?: string | undefined;
readonly persistedMetadata?: JsonCompatibleReadOnlyObject | undefined;
}

// @public @system
Expand Down Expand Up @@ -176,6 +177,14 @@ export interface ITreeViewConfiguration<TSchema extends ImplicitFieldSchema = Im
readonly schema: TSchema;
}

// @public
export type JsonCompatibleReadOnly = string | number | boolean | null | readonly JsonCompatibleReadOnly[] | JsonCompatibleReadOnlyObject;

// @public
export type JsonCompatibleReadOnlyObject = {
readonly [P in string]?: JsonCompatibleReadOnly;
};

// @public
export type LazyItem<Item = unknown> = Item | (() => Item);

Expand Down Expand Up @@ -222,6 +231,7 @@ export enum NodeKind {
export interface NodeSchemaMetadata<out TCustomMetadata = unknown> {
readonly custom?: TCustomMetadata | undefined;
readonly description?: string | undefined;
readonly persistedMetadata?: JsonCompatibleReadOnlyObject | undefined;
}

// @public @sealed
Expand Down
10 changes: 10 additions & 0 deletions packages/dds/tree/api-report/tree.public.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ export class FieldSchema<out Kind extends FieldKind = FieldKind, out Types exten
export interface FieldSchemaMetadata<TCustomMetadata = unknown> {
readonly custom?: TCustomMetadata;
readonly description?: string | undefined;
readonly persistedMetadata?: JsonCompatibleReadOnlyObject | undefined;
}

// @public @system
Expand Down Expand Up @@ -176,6 +177,14 @@ export interface ITreeViewConfiguration<TSchema extends ImplicitFieldSchema = Im
readonly schema: TSchema;
}

// @public
export type JsonCompatibleReadOnly = string | number | boolean | null | readonly JsonCompatibleReadOnly[] | JsonCompatibleReadOnlyObject;

// @public
export type JsonCompatibleReadOnlyObject = {
readonly [P in string]?: JsonCompatibleReadOnly;
};

// @public
export type LazyItem<Item = unknown> = Item | (() => Item);

Expand Down Expand Up @@ -222,6 +231,7 @@ export enum NodeKind {
export interface NodeSchemaMetadata<out TCustomMetadata = unknown> {
readonly custom?: TCustomMetadata | undefined;
readonly description?: string | undefined;
readonly persistedMetadata?: JsonCompatibleReadOnlyObject | undefined;
}

// @public @sealed
Expand Down
4 changes: 3 additions & 1 deletion packages/dds/tree/src/core/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,13 @@ export {
storedEmptyFieldSchema,
type StoredSchemaCollection,
schemaFormatV1,
schemaFormatV2,
LeafNodeStoredSchema,
ObjectNodeStoredSchema,
MapNodeStoredSchema,
decodeFieldSchema,
encodeFieldSchema,
encodeFieldSchemaV1,
encodeFieldSchemaV2,
storedSchemaDecodeDispatcher,
type SchemaAndPolicy,
Multiplicity,
Expand Down
54 changes: 54 additions & 0 deletions packages/dds/tree/src/core/schema-stored/formatV2.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
/*!
* Copyright (c) Microsoft Corporation and contributors. All rights reserved.
* Licensed under the MIT License.
*/

import { type ObjectOptions, type Static, Type } from "@sinclair/typebox";

import { JsonCompatibleReadOnlySchema } from "../../util/index.js";
import {
FieldKindIdentifierSchema,
TreeNodeSchemaIdentifierSchema,
TreeNodeSchemaDataFormat as TreeNodeSchemaUnionFormat,
} from "./formatV1.js";

export const PersistedMetadataFormat = Type.Optional(JsonCompatibleReadOnlySchema);

const FieldSchemaFormatBase = Type.Object({
kind: FieldKindIdentifierSchema,
types: Type.Array(TreeNodeSchemaIdentifierSchema),
metadata: PersistedMetadataFormat,
});

const noAdditionalProps: ObjectOptions = { additionalProperties: false };

export const FieldSchemaFormat = Type.Composite([FieldSchemaFormatBase], noAdditionalProps);

/**
* Format for {@link TreeNodeStoredSchema}.
*
* See {@link DiscriminatedUnionDispatcher} for more information on this pattern.
*/
export const TreeNodeSchemaDataFormat = Type.Object(
{
/**
* Node kind specific data.
*/
kind: TreeNodeSchemaUnionFormat,

// Data in common for all TreeNode schemas:
/**
* Leaf node union member.
*/
metadata: PersistedMetadataFormat,
},
noAdditionalProps,
);

export type TreeNodeSchemaDataFormat = Static<typeof TreeNodeSchemaDataFormat>;

export type FieldSchemaFormat = Static<typeof FieldSchemaFormat>;

export type PersistedMetadataFormat = Static<typeof PersistedMetadataFormat>;

export { TreeNodeSchemaUnionFormat };
5 changes: 4 additions & 1 deletion packages/dds/tree/src/core/schema-stored/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ export {
ObjectNodeStoredSchema,
MapNodeStoredSchema,
decodeFieldSchema,
encodeFieldSchema,
encodeFieldSchemaV1,
encodeFieldSchemaV2,
storedSchemaDecodeDispatcher,
type SchemaAndPolicy,
type SchemaPolicy,
Expand All @@ -37,3 +38,5 @@ export type { TreeNodeSchemaIdentifier, FieldKey, FieldKindIdentifier } from "./

import * as schemaFormatV1 from "./formatV1.js";
export { schemaFormatV1 };
import * as schemaFormatV2 from "./formatV2.js";
export { schemaFormatV2 };
Loading