-
Notifications
You must be signed in to change notification settings - Fork 549
Bump patch version and type tests #24475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump patch version and type tests #24475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 183 out of 203 changed files in this pull request and generated no comments.
Files not reviewed (20)
- azure/packages/azure-local-service/package.json: Language not supported
- azure/packages/azure-service-utils/package.json: Language not supported
- examples/apps/ai-collab/package.json: Language not supported
- examples/apps/attributable-map/package.json: Language not supported
- examples/apps/blobs/package.json: Language not supported
- examples/apps/collaborative-textarea/package.json: Language not supported
- examples/apps/contact-collection/package.json: Language not supported
- examples/apps/data-object-grid/package.json: Language not supported
- examples/apps/presence-tracker/package.json: Language not supported
- examples/apps/staging/package.json: Language not supported
- examples/apps/task-selection/package.json: Language not supported
- examples/apps/tree-cli-app/package.json: Language not supported
- examples/apps/tree-comparison/package.json: Language not supported
- examples/benchmarks/bubblebench/baseline/package.json: Language not supported
- examples/benchmarks/bubblebench/common/package.json: Language not supported
- examples/benchmarks/bubblebench/experimental-tree/package.json: Language not supported
- examples/benchmarks/bubblebench/ot/package.json: Language not supported
- examples/benchmarks/bubblebench/shared-tree/package.json: Language not supported
- examples/benchmarks/odspsnapshotfetch-perftestapp/package.json: Language not supported
- examples/benchmarks/tablebench/package.json: Language not supported
Warning WARNING: This PR is targeting a release branch! All changes must first be merged into Changes to release branches require approval from the Patch Triage group before merging. For more details, see our internal documentation for the patch policy and processes for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be confusing while reviewing merging type tests and version bump in one PR. As a reviewer it takes a bit more checking that the number being updated is the correct one for each operation. It saves the release engineer some time but it increases it to the one reviewing which maybe it's desired but I can easily see how the reviewer misses one number being updated wrong or not knowing for sure which number we should update to.
Given that CI would fail if the package versions mismatched, and all the changes here are automated, I don't think there is much risk. Also, the main reason to combine these is to avoid having to get approval for two distinct changes to the release branch (To save Frank and Borris time). I suppose we could have the best of both cases if it was done in one PR with two commits so they could be reviewed together or separately at the reviewer's choice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this PR.
e809ac8
into
microsoft:release/client/2.33
Description
Update patch version and type tests
Reviewer Guidance
The review process is outlined on this wiki page.