Skip to content

feat(client-presence): Create Acknowledgment message interface and ackRequested flow #24470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jun 2, 2025
Merged
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions packages/framework/presence/src/presenceDatastoreManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,19 @@ interface ClientJoinMessage extends IInboundSignalMessage {
};
}

const acknowledgementMessageType = "Pres:Ack";

interface AcknowledgementMessage extends IInboundSignalMessage {
type: typeof acknowledgementMessageType;
content: {
sendTimestamp: number;
avgLatency: number;
};
}

function isPresenceMessage(
message: IInboundSignalMessage,
): message is DatastoreUpdateMessage | ClientJoinMessage {
): message is DatastoreUpdateMessage | ClientJoinMessage | AcknowledgementMessage {
return message.type.startsWith("Pres:");
}
/**
Expand Down Expand Up @@ -356,7 +366,11 @@ export class PresenceDatastoreManagerImpl implements PresenceDatastoreManager {
// IExtensionMessage is a subset of IInboundSignalMessage so this is safe.
// Change types of DatastoreUpdateMessage | ClientJoinMessage to
// IExtensionMessage<> derivatives to see the issues.
message: IInboundSignalMessage | DatastoreUpdateMessage | ClientJoinMessage,
message:
| IInboundSignalMessage
| DatastoreUpdateMessage
| ClientJoinMessage
| AcknowledgementMessage,
local: boolean,
): void {
const received = Date.now();
Expand Down Expand Up @@ -390,6 +404,9 @@ export class PresenceDatastoreManagerImpl implements PresenceDatastoreManager {
}
// It is okay to continue processing the contained updates even if we are not
// connected.
} else if (message.type === acknowledgementMessageType) {
// TODO: Handle acknowledgement message type.
return;
} else {
assert(message.type === datastoreUpdateMessageType, 0xa3b /* Unexpected message type */);
if (message.content.isComplete) {
Expand Down
Loading