Skip to content

Update client to ES2022 #24324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 98 additions & 0 deletions .changeset/cyan-experts-nail.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
---
"@fluidframework/agent-scheduler": minor
"@fluidframework/ai-collab": minor
"@fluidframework/app-insights-logger": minor
"@fluidframework/aqueduct": minor
"@fluid-experimental/attributable-map": minor
"@fluid-experimental/attributor": minor
"@fluidframework/azure-client": minor
"@fluidframework/azure-end-to-end-tests": minor
"@fluidframework/azure-local-service": minor
"@fluidframework/azure-service-utils": minor
"@fluidframework/cell": minor
"@fluidframework/container-definitions": minor
"@fluidframework/container-loader": minor
"@fluidframework/container-runtime": minor
"@fluidframework/container-runtime-definitions": minor
"@fluidframework/core-interfaces": minor
"@fluidframework/core-utils": minor
"@fluidframework/counter": minor
"@fluid-experimental/data-object-base": minor
"@fluid-experimental/data-objects": minor
"@fluidframework/datastore": minor
"@fluidframework/datastore-definitions": minor
"@fluid-experimental/dds-interceptions": minor
"@fluidframework/debugger": minor
"@fluidframework/devtools": minor
"@fluidframework/devtools-core": minor
"@fluidframework/driver-base": minor
"@fluidframework/driver-definitions": minor
"@fluidframework/driver-utils": minor
"@fluidframework/driver-web-cache": minor
"@fluid-tools/fetch-tool": minor
"@fluidframework/file-driver": minor
"fluid-framework": minor
"@fluidframework/fluid-runner": minor
"@fluidframework/fluid-static": minor
"@fluidframework/fluid-telemetry": minor
"@fluidframework/id-compressor": minor
"@fluid-experimental/ink": minor
"@fluid-experimental/last-edited": minor
"@fluidframework/local-driver": minor
"@fluidframework/map": minor
"@fluidframework/matrix": minor
"@fluidframework/merge-tree": minor
"@fluidframework/odsp-client": minor
"@fluidframework/odsp-doclib-utils": minor
"@fluidframework/odsp-driver": minor
"@fluidframework/odsp-driver-definitions": minor
"@fluid-experimental/odsp-end-to-end-tests": minor
"@fluidframework/odsp-urlresolver": minor
"@fluid-experimental/oldest-client-observer": minor
"@fluidframework/ordered-collection": minor
"@fluid-experimental/ot": minor
"@fluid-experimental/pact-map": minor
"@fluidframework/presence": minor
"@fluid-experimental/property-changeset": minor
"@fluidframework/register-collection": minor
"@fluidframework/replay-driver": minor
"@fluidframework/request-handler": minor
"@fluidframework/routerlicious-driver": minor
"@fluidframework/routerlicious-urlresolver": minor
"@fluidframework/runtime-definitions": minor
"@fluidframework/runtime-utils": minor
"@fluidframework/sequence": minor
"@fluid-experimental/sequence-deprecated": minor
"@fluidframework/shared-object-base": minor
"@fluidframework/shared-summary-block": minor
"@fluid-experimental/sharejs-json1": minor
"@fluid-private/stochastic-test-utils": minor
"@fluidframework/synthesize": minor
"@fluidframework/task-manager": minor
"@fluidframework/telemetry-utils": minor
"@fluid-private/test-dds-utils": minor
"@fluid-private/test-drivers": minor
"@fluid-private/test-end-to-end-tests": minor
"@fluid-private/test-loader-utils": minor
"@fluid-private/test-pairwise-generator": minor
"@fluidframework/test-runtime-utils": minor
"@fluidframework/test-utils": minor
"@fluid-private/test-version-utils": minor
"@fluidframework/tinylicious-client": minor
"@fluidframework/tinylicious-driver": minor
"@fluidframework/tool-utils": minor
"@fluid-experimental/tree": minor
"@fluidframework/tree": minor
"@fluid-experimental/tree-react-api": minor
"@fluidframework/undo-redo": minor
"__section": other
---
Build packages targeting ES2022

Packages are now build targeting ES2022.
This results in reduces bundle size (Measured at 2% for SharedTree) and improves developer experience in debuggers due to JavaScript private fields being visible.

Fluid Framework has not officially supported targets older than ES2022 since before 2.0: this is documented in [ClientRequirements.md](https://github.com/microsoft/FluidFramework/blob/main/ClientRequirements.md) as well as the ReadMe for every client package.
This change does not involve any change to what is officially supported.
It is possible this change could impact users less up to date JavaScript runtimes:

Check failure on line 97 in .changeset/cyan-experts-nail.md

View workflow job for this annotation

GitHub Actions / vale

[vale] reported by reviewdog 🐶 [Vale.Spelling] Did you really mean 'runtimes'? Raw Output: {"message": "[Vale.Spelling] Did you really mean 'runtimes'?", "location": {"path": ".changeset/cyan-experts-nail.md", "range": {"start": {"line": 97, "column": 74}}}, "severity": "ERROR"}
such users can use a tool like [babel](https://babeljs.io/) to transpile out unsupported language features.

Check failure on line 98 in .changeset/cyan-experts-nail.md

View workflow job for this annotation

GitHub Actions / vale

[vale] reported by reviewdog 🐶 [Vale.Spelling] Did you really mean 'transpile'? Raw Output: {"message": "[Vale.Spelling] Did you really mean 'transpile'?", "location": {"path": ".changeset/cyan-experts-nail.md", "range": {"start": {"line": 98, "column": 64}}}, "severity": "ERROR"}
2 changes: 1 addition & 1 deletion common/build/build-common/tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"pretty": true,
"sourceMap": true,
"strict": true,
"target": "ES2021",
"target": "ES2022",
"types": [],
// Enabling these compiler flags is necessary for typechecking compliance with semver as per https://www.semver-ts.org/
// See specifically https://www.semver-ts.org/formal-spec/5-compiler-considerations.html#strictness.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
"composite": true,
"rootDir": "./src",
"outDir": "./dist",
// Updating to ES 2022 causes some failing tests.
// Resolving these issues is not a priority right now.
"target": "ES2021",
},
"include": ["src/**/*"],
"exclude": ["src/test/**/*"],
Expand Down
3 changes: 3 additions & 0 deletions experimental/PropertyDDS/packages/property-dds/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
"types": ["node"],
"noUncheckedIndexedAccess": false,
"exactOptionalPropertyTypes": false,
// Updating to ES 2022 causes some failing tests.
// Resolving these issues is not a priority right now.
"target": "ES2021",
},
"include": ["src/**/*"],
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"rootDir": "./src",
"outDir": "./dist",
"composite": true,
// Updating to ES 2022 causes some failing tests.
// Resolving these issues is not a priority right now.
"target": "ES2021",
},
"include": ["src/**/*"],
}
Loading