-
Notifications
You must be signed in to change notification settings - Fork 549
build: Add vale configuration and demonstrate usage #24252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 11 commits
800cad5
7e08e3e
41f77fa
829d7de
b457d62
efb81c5
ecd4427
5019611
8239827
149e438
0585811
b55188c
6f1ba47
a8ea0a1
3894624
26d00b0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,9 @@ | ||
--- | ||
"@fluidframework/container-loader": minor | ||
--- | ||
--- | ||
"section": feature | ||
"__section": feature | ||
--- | ||
|
||
Blobs in Detached Container Supported by Default | ||
|
||
It is no longer necessary or supported to provide `detachedBlobStorage` to the Loader. This functionality is now provided by default, and the deprecated `IDetachedBlobStorage` will be removed in the 2.40.0 release. | ||
The new behavior can be disabled by setting `Fluid.Container.MemoryBlobStorageEnabled` to `false`. This flag will also be removed in the 2.40.0 release if no issues are reported. | ||
Check warning on line 9 in .changeset/true-doors-ring.md
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
name: "pr-changeset-review" | ||
|
||
# This workflow runs lint-like checks against changesets in PRs. The linting tool used is called Vale. The worflow will | ||
# add comments for any issues warnings or errors that Vale finds in the changeset. | ||
tylerbutler marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
# To run vale locally against changesets, you can use `pnpm run check:changesets`. | ||
|
||
on: | ||
pull_request: | ||
types: | ||
- opened # PR is created | ||
- synchronize # commits added to PR | ||
- reopened # closed PR re-opened | ||
branches: | ||
- main | ||
paths: | ||
- ".changeset/**" # Trigger only when changes are found under .changeset | ||
|
||
permissions: | ||
pull-requests: write | ||
|
||
jobs: | ||
vale: | ||
name: vale | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # ratchet:actions/checkout@v3 | ||
with: | ||
persist-credentials: false | ||
- uses: errata-ai/vale-action@v2.1.1 | ||
tylerbutler marked this conversation as resolved.
Show resolved
Hide resolved
|
||
with: | ||
files: .changeset | ||
vale_flags: "--glob=*-*-*.md" | ||
reporter: github-pr-review | ||
filter_mode: nofilter |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,15 @@ nyc | |
*.log | ||
.DS_Store | ||
|
||
.vale/* | ||
!.vale/config/ | ||
|
||
.vale/config/* | ||
!.vale/config/vocabularies/ | ||
|
||
.vale/config/vocabularies/* | ||
!.vale/config/vocabularies/fluid/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isn't it enough to have There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For reasons I don't understand, no. If you do that, and add a new file under .vale/config/vocabularies/fluid/, it will |
||
|
||
# Generated Node10 module resolution compatibility files | ||
alpha.d.ts | ||
beta.d.ts | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
StylesPath = .vale | ||
|
||
MinAlertLevel = suggestion | ||
|
||
Packages = Microsoft, MDX, proselint | ||
|
||
Vocab = fluid | ||
|
||
[*README.md] | ||
Microsoft.We = NO | ||
|
||
[*.{md}] | ||
BasedOnStyles = Vale, Microsoft, proselint | ||
|
||
; Note that only errors will be reported in GitHub PR comments. | ||
; This seems to be a limitation of the GitHub Action. | ||
; When running locally, all levels will be reported. | ||
Microsoft.Contractions = NO | ||
Microsoft.Passive = NO | ||
Microsoft.Terms = suggestion | ||
Microsoft.Vocab = NO |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
Fluid Framework | ||
FluidFramework | ||
JavaScript | ||
SharedTree | ||
TypeScript |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
shared tree | ||
tylerbutler marked this conversation as resolved.
Show resolved
Hide resolved
|
Uh oh!
There was an error while loading. Please reload this page.