Skip to content

tree: Refactor changesets to use an attach-detach model #24139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 148 commits into
base: main
Choose a base branch
from
Draft

tree: Refactor changesets to use an attach-detach model #24139

wants to merge 148 commits into from

Conversation

alex-pardes
Copy link
Contributor

Description

alex-pardes and others added 30 commits November 19, 2024 10:01
@alex-pardes
WIP detached roots
eddcaed
@alex-pardes
Update generated file
e527e78
@alex-pardes
Merge remote-tracking branch 'upstream/main' into detached-roots
8d32463
@alex-pardes
WIP
3d2f7c9
@alex-pardes
WIP
17622a4
@alex-pardes
WIP
61b4359
@alex-pardes
Remove unused function
af66f01
@alex-pardes
Merge remote-tracking branch 'upstream/main' into detached-roots
053db3b
@alex-pardes
Update rename table implementation
a3ce70c
@alex-pardes
Remove detached node effects from field deltas and fix bug with node …
0066f37 
…renaming
@alex-pardes
Support value ranges in RangeMap
1b51b57
@alex-pardes
Merge branch 'value-ranges' into detached-roots
bb84aa1
@alex-pardes
Use value ranges in node rename table
bca8158
@alex-pardes
Merge remote-tracking branch 'upstream/main' into detached-roots
eac4309
@alex-pardes
Fix issues with rebasing scenarios
6da2383
@alex-pardes
Cleanup
5e555ff
@alex-pardes
Fix bug
8a5aab5
@alex-pardes
Handle split renames
cf79f10
@alex-pardes
Correctly compose renames
0bced5a
@alex-pardes
Store edits to detached roots
aba1400
@alex-pardes
Handle composition of detached nodes
7b514c4
@alex-pardes
Reimplement optional field
129a716
@alex-pardes
Fix bug with composing rename and attach
9d333cf
@alex-pardes
Fixed bug with sequence field cross field keys
db7dd80
@alex-pardes
Fix inval
6e817be
@alex-pardes
Give detached nodes ID indepedent from cell
4fc8ae4
@alex-pardes
Fix optional field rebasing
e71a482
@alex-pardes
Fix bug with composing rename tables
a065066
@alex-pardes
Correctly determine whether optional field detach and attach should c…
879627f 
…ancel out
@alex-pardes
Cleanup
269316c
alex-pardes and others added 29 commits May 19, 2025 18:31
@alex-pardes
Fix bug with splitting renames during rebasing
b35a9c0
@alex-pardes
Cleanup
6b949d1
@alex-pardes
Remove TODO
99dec7c
@alex-pardes
Remove unused case in sequence invert
c89453f
@alex-pardes
Cleanup
4046462
@alex-pardes
Replace the terms insert/remove with attach/detach
0697acd
@yann-achard-MS
editing.spec tests
a39f1e0
@alex-pardes
Remove TODO
3b658ee
@alex-pardes
Cleanup imports
78b2724
@alex-pardes
Fix encoding
466f9bf
@alex-pardes
Fix deserialization, rebasing bug
eded733
@alex-pardes
Fix V2 serialization of renames
c8fbf48
@alex-pardes
Fix bug where field IDs were not normalized
9b5d2ec
@alex-pardes
Fix bug with sequence invert
01dcf44
@alex-pardes
Fix bug with rebasing moved nodes
d367ee4
@alex-pardes
Fix bug with relevant removed roots
e3f684a
@alex-pardes
Fix bug with splitting in rebaseOverDetach
463a33a
@alex-pardes
Handle encoding of optional field children
8a4ab1d
@alex-pardes
Split off an areSameNodes method from composeDetachAttach
0d8dd25
@alex-pardes
Fix optional field rollbacks
8a93f4e
@alex-pardes
Fix bug with rebasing detached roots
36b1f6a
@alex-pardes
Fix bug with splitting in rebaseOverDetach
7019a34
@alex-pardes
Fix bug with rebasing over move to renamed detached root
dbfb71a
@alex-pardes
Fix bug with rebasing root node tables
f5ef251
@alex-pardes
Fix bug where composition could get stuck in infinite loop
d349ad8
@alex-pardes
Fix bug where input changeset could be mutated in composition
e766216
@alex-pardes
Fix bug with updating parentage when inverting
af97c41
@alex-pardes
Fix bug with optional field rebase
109f550
@alex-pardes
WIP support optional field moves
9645ea0
@github-actions github-actions bot added the public api change Changes to a public API label Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yann-achard-MS yann-achard-MS yann-achard-MS left review comments

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: dds: tree area: dds Issues related to distributed data structures base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-pardes @yann-achard-MS