Remove containerPackageInfo parameter in createOdspCreateContainerRequest

[MarioJGMsoft]

Description

With PR: #22849 we introduced a parameter for ODSP that will not be used.
Since it is public, we will first mark it as deprecated, and then in the next release remove it. Make sure we inform Loop to not take dependency on it.

This is the follow up task to ensure that the parameter is deleted.

Reviewer Guidance

Please let me know if there's anything that I should change or be aware of. Thanks!

Fixes: AB#31049

[Copilot]

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

packages/drivers/odsp-driver/src/createOdspCreateContainerRequest.ts:35

• With the removal of the containerPackageInfo parameter and its associated URL fragment, please ensure that any parts of the system relying on containerPackageName being sent through createOdspCreateContainerRequest are updated (for example, by using OdspDriverUrlResolverForShareLink as described).

)}${shareLinkRequestParams ? `&${shareLinkRequestParams}` : ""}`,

packages/drivers/odsp-driver/src/test/odspDriverResolverTest.spec.ts:457

• The removal of the containerPackageInfo parameter led to the deletion of this test case. Please confirm that the new behavior (i.e. setting the container package name via OdspDriverUrlResolverForShareLink) is covered elsewhere in the tests.

it("Should create request with containerPackageName and resolve it", async () => {

[tylerbutler]

Blocking merge only to help with release race-conditions. I'll remove this block once release branch is created.

Release is unblocked.

[jason-ha]

This is a breaking behavioral change. Is there a deprecation PR planned before this?

[MarioJGMsoft]

Yes there is, I'm working on one but I'm having trouble making the deprecation. I'm not sure how to deprecate the parameter within the function.

[jason-ha]

You can't deprecate the parameter, but you can deprecate calling the function with that form. Example:

interface Test {
  /** @deprecated */
  fn(a: string, b: boolean): void;
  fn(a: string): void;
}

[MarioJGMsoft]

Created deprecation PR: #23919

[github-actions]

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output

> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

http://localhost:3000/docs/data-structures/tree
- (36:97) 'the Shar..' => http://localhost:3000/docs/api/tree (HTTP 404)

http://localhost:3000/docs/data-structures/tree/
- (36:97) 'the Shar..' => http://localhost:3000/docs/api/tree (HTTP 404)

http://localhost:3000/docs/data-structures/tree/schema-definition
- (30:128) 'SharedTr..' => http://localhost:3000/docs/api/tree (HTTP 404)

http://localhost:3000/docs/start/tree-start
- (44:4) 'the API ..' => http://localhost:3000/docs/api/tree/schemafactory-class (HTTP 404)
- (61:7) 'the API' => http://localhost:3000/docs/api/tree/treechangeevents-interface (HTTP 404)


Stats:
  162477 links
    1326 destination URLs
    1558 URLs ignored
       0 warnings
       3 errors

 ELIFECYCLE  Command failed with exit code 1.