[SM 6.9] Fix OuterProductAccumulate FP32 Accumulator case in ExecTest. #7482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
VladM1076
changed the title
damyanp
approved these changes
May 24, 2025
tex3d
approved these changes
May 24, 2025
|
TY for quick review, have a good weekend! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switch that sets SrcEltSize and DestEltSize is missing an FP32 case.
This results in the matrix buffer not being initialized with all 1.0s and causes tests to fail due to expected result being off by -1.0.
Verified correctness with NVIDIA internal driver build.