Skip to content

[SEMA] Don't emit an error for sizeof an enum. #7449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2025
Merged

[SEMA] Don't emit an error for sizeof an enum. #7449

merged 2 commits into from
May 16, 2025

Conversation

s-perron
Copy link
Collaborator

Fixes #7416

@s-perron s-perron requested review from Keenuts and cassiebeckley May 12, 2025 15:33
@s-perron s-perron requested a review from tex3d May 12, 2025 18:01
llvm-beanz
llvm-beanz approved these changes May 16, 2025
View reviewed changes
Copy link
Collaborator

@llvm-beanz llvm-beanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I wonder if this also fixes #3860 or #5095.

@s-perron s-perron merged commit 7054e52 into microsoft:main May 16, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap May 16, 2025
This was referenced May 19, 2025
Closed
Closed
@llvm-beanz
Copy link
Collaborator

Woo! Thank you @s-perron! Looks like this fixed both of the linked issues 😁

@s-perron s-perron deleted the i7416 branch May 28, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cassiebeckley cassiebeckley cassiebeckley approved these changes

@llvm-beanz llvm-beanz llvm-beanz approved these changes

@Keenuts Keenuts Awaiting requested review from Keenuts

@tex3d tex3d Awaiting requested review from tex3d

Assignees
No one assigned
Labels
None yet
Projects
HLSL Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SPIR-V] sizeof() error when structcontains enum or enum class
3 participants
@s-perron @llvm-beanz @cassiebeckley