-
Notifications
You must be signed in to change notification settings - Fork 75
Introduces support for streaming text responses in the Activity Proto… #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gurubhg
wants to merge
1
commit into
main
Choose a base branch
from
users/guhiriya/activity_schema_changes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracyboehrer
requested changes
Jun 4, 2025
90f5b55
to
13b6e23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for streaming text responses by introducing a new streaminfo
entity and updating the Activity Protocol documentation accordingly.
- Defines the
streaminfo
entity schema and streaming guidelines. - Adds
streaminfo
to Appendix II’s non-IRI entity list and provides usage examples. - Updates version, changelog entry under Appendix I, and provides fallback instructions for unsupported channels.
Comments suppressed due to low confidence (3)
specs/activity/protocol-activity.md:1533
- The changelog bullet omits
streamId
, which is a required property in the new entity schema. Please includestreamId
in this summary.
* Defined `streamType`, `streamSequence`, and optional `streamResult`
specs/activity/protocol-activity.md:1650
- The entity type is defined elsewhere as
streaminfo
(all lowercase). Please unify the casing in this table row tostreaminfo
for consistency.
| streamInfo | N/A | Streaming text metadata |
specs/activity/protocol-activity.md:1704
- Other entity property tables use
number
as the type for numeric fields. Consider changinginteger
tonumber
to maintain consistency.
| `streamSequence` | integer | Yes | Incrementing sequence number for each chunk for non-final messages |
…col via a new streaminfo entity. - Definition of the `streaminfo` entity. - Guidelines for using streaminfo in typing and message Activities to send chunked text responses. - Addition of streaminfo to the list of supported non-IRI entity types in Appendix II. - Documentation update with examples and a changelog entry under Appendix I.
13b6e23
to
80c6bd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…col via a new streaminfo entity.
streaminfo
entity.Related to #36
See also #27