Workload Identity #320
Draft
Workload Identity #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ML: Core
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for WorkloadIdentity authentication alongside existing federated credentials. Key changes include new tests covering WorkloadIdentity scenarios, updates to the MSAL authentication flow to handle WorkloadIdentity, and modifications to configuration settings and interfaces to support the new authentication type.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/tests/Microsoft.Agents.Authentication.Msal.Tests/Model/ConnectionSettingsTests.cs | Added tests for FederatedCredentials, WorkloadIdentity, and AssertionRequestOptions |
| src/libraries/Authentication/Authentication.Msal/MsalAuth.cs | Updated the client assertion logic for FederatedCredentials and added a branch for WorkloadIdentity |
| src/libraries/Authentication/Authentication.Msal/Model/ConnectionSettings.cs | Introduced new properties (FederatedTokenFile and AssertionRequestOptions) and updated validation for WorkloadIdentity |
| src/libraries/Authentication/Authentication.Msal/Model/AuthTypes.cs | Extended enum to include WorkloadIdentity |
| src/libraries/Authentication/Authentication.Msal/Interfaces/IMSALConnectionSettings.cs | Updated interface to support new properties for WorkloadIdentity |
src/libraries/Authentication/Authentication.Msal/Model/ConnectionSettings.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #317
Matching doc: microsoft/Agents#182