Fix split install issue #2898

DaVinci9196 · 2025-05-08T01:38:35Z

Extract the optimization and resubmit it to #2799

Download notifications for split packages should be dismissible.
After a split package is downloaded, clicking the notification should trigger installation (to handle cases where the install prompt can't appear due to a locked screen).
Prevent multiple notifications for the same split package download.
Remove notifications when the network is disconnected or the download fails.
Implement resumable downloads to save data usage.
Ensure device synchronization to avoid missing split package information.
Support account elevation to prevent failure in accessing split package data.

fynngodau

Thanks for these improvements. I think resumable downloads, and only downloading one split install package at a time, really make sense. However, I would prefer a different implementation approach: the way you are doing it is that the packages are first downloaded to a temporary directory, and then copied to the install session from this directory. (A previous iteration of the code also had this behavior, but we changed it to avoid occupying 2× the space of the installed package while installing it.)

I think it should be possible to instead resume downloads into the pending session. To do this:

We need a registry of session IDs, so we know which download corresponds to which session.
Sessions must not be discarded when download fails.
We don't need temporary files anymore.

Do you see any reason that speaks against implementing it like this?

vending-app/src/main/kotlin/com/android/vending/installer/Install.kt

vending-app/src/main/java/org/microg/vending/ui/InstallProgressNotification.kt

vending-app/src/main/java/org/microg/vending/delivery/Delivery.kt

...ing-app/src/main/kotlin/com/google/android/finsky/splitinstallservice/SplitInstallManager.kt

vending-app/src/main/java/org/microg/vending/delivery/Delivery.kt

vending-app/src/main/kotlin/com/android/vending/installer/Install.kt

DaVinci9196 · 2025-06-16T06:30:37Z

Thanks for these improvements. I think resumable downloads, and only downloading one split install package at a time, really make sense. However, I would prefer a different implementation approach: the way you are doing it is that the packages are first downloaded to a temporary directory, and then copied to the install session from this directory. (A previous iteration of the code also had this behavior, but we changed it to avoid occupying 2× the space of the installed package while installing it.)

I think it should be possible to instead resume downloads into the pending session. To do this:

We need a registry of session IDs, so we know which download corresponds to which session.

Sessions must not be discarded when download fails.

We don't need temporary files anymore.

Do you see any reason that speaks against implementing it like this?

We temporarily store the downloaded files locally to avoid repeated downloads in case of issues, which could lead to unnecessary data usage for users.
Regarding your suggestion of resuming directly into the install session — isn’t there a limitation on how many active sessions the system allows?
That’s part of the reason we initially chose to manage downloads outside the session system.

fynngodau · 2025-06-16T06:53:07Z

Regarding your suggestion of resuming directly into the install session — isn’t there a limitation on how many active sessions the system allows?

I don't know if there is such a limit. What do you expect the limit to be? What happens if it is exceeded? Do you expect to open many sessions, i.e. many partial and failed downloads? This would also mean a large storage consumption in either implementation, so it's not really desirable in either implementation.

DaVinci9196 · 2025-06-16T07:55:11Z

Regarding your suggestion of resuming directly into the install session — isn’t there a limitation on how many active sessions the system allows?

I don't know if there is such a limit. What do you expect the limit to be? What happens if it is exceeded? Do you expect to open many sessions, i.e. many partial and failed downloads? This would also mean a large storage consumption in either implementation, so it's not really desirable in either implementation.

This is just an extreme case because Marvin initially raised concerns about data usage with me. That’s why I chose this approach.
Regarding your suggestion of tracking through sessions, wouldn’t the sessions be lost if the app is killed?

fynngodau · 2025-06-16T08:11:49Z

Regarding your suggestion of tracking through sessions, wouldn’t the sessions be lost if the app is killed?

The session will even be persisted across multiple boots, please refer to: https://developer.android.com/reference/android/content/pm/PackageInstaller#createSession(android.content.pm.PackageInstaller.SessionParams)

DaVinci9196 · 2025-06-16T08:26:30Z

Regarding your suggestion of tracking through sessions, wouldn’t the sessions be lost if the app is killed?

The session will even be persisted across multiple boots, please refer to: https://developer.android.com/reference/android/content/pm/PackageInstaller#createSession(android.content.pm.PackageInstaller.SessionParams)

So do we need to store the sessions locally to facilitate reuse later?
If we use this method, how can we track the split package download progress, and how can we implement resumable downloads?

DaVinci9196 · 2025-06-16T09:36:25Z

Regarding your suggestion of tracking through sessions, wouldn’t the sessions be lost if the app is killed?

The session will even be persisted across multiple boots, please refer to: https://developer.android.com/reference/android/content/pm/PackageInstaller#createSession(android.content.pm.PackageInstaller.SessionParams)

I think your solution still cannot meet the requirements for resumable downloads in special cases.

fynngodau · 2025-06-16T10:25:45Z

Yes, as I mentioned, we could use a registry of session IDs, so we know which download corresponds to which session. Since we are session owner, we might also be able to use: https://developer.android.com/reference/kotlin/android/content/pm/PackageInstaller?hl=en#getStagedSessions() and compare the package name of the session.

I suppose we might need to store how many bytes we wrote to the session, if it's not possible to ask the session that, though it might be feasible to use: https://developer.android.com/reference/kotlin/android/content/pm/PackageInstaller.Session?hl=en#openRead(kotlin.String)

What special cases do you have in mind?

DaVinci9196 · 2025-06-17T08:43:39Z

Yes, as I mentioned, we could use a registry of session IDs, so we know which download corresponds to which session. Since we are session owner, we might also be able to use: https://developer.android.com/reference/kotlin/android/content/pm/PackageInstaller?hl=en#getStagedSessions() and compare the package name of the session.

I suppose we might need to store how many bytes we wrote to the session, if it's not possible to ask the session that, though it might be feasible to use: https://developer.android.com/reference/kotlin/android/content/pm/PackageInstaller.Session?hl=en#openRead(kotlin.String)

What special cases do you have in mind?

I tried using your method, but I kept getting the following error when calling openSession: java.lang.SecurityException: Caller has no access to session 2068134291. @fynngodau

fynngodau · 2025-06-17T15:32:08Z

@DaVinci9196 Can you provide me with the code where this issue occurs? That will make it much easier for me to find out why that could be the case.

DaVinci9196 · 2025-06-18T01:59:24Z

@DaVinci9196 Can you provide me with the code where this issue occurs? That will make it much easier for me to find out why that could be the case.

Install.txt
I modified Install.kt to Install.txt and uploaded it。
The core code is as follows. An error occurs when calling openSession

val cacheSessionId = SessionStorage.getInstance(this).getSessionId(key)
        sessionId = if (cacheSessionId == -1) {
            packageInstaller.createSession(params)
        } else {
            cacheSessionId
        }
        for (info in packageInstaller.allSessions) {
            Log.d(TAG, "id=${info.sessionId}, createdBy=${info.installerPackageName}")
        }

        SessionStorage.getInstance(this).saveSessionId(key, sessionId)
        session = packageInstaller.openSession(sessionId)

DaVinci9196 · 2025-06-24T08:52:46Z

@DaVinci9196 Can you provide me with the code where this issue occurs? That will make it much easier for me to find out why that could be the case.

Install.txt I modified Install.kt to Install.txt and uploaded it。 The core code is as follows. An error occurs when calling openSession
val cacheSessionId = SessionStorage.getInstance(this).getSessionId(key)
        sessionId = if (cacheSessionId == -1) {
            packageInstaller.createSession(params)
        } else {
            cacheSessionId
        }
        for (info in packageInstaller.allSessions) {
            Log.d(TAG, "id=${info.sessionId}, createdBy=${info.installerPackageName}")
        }

        SessionStorage.getInstance(this).saveSessionId(key, sessionId)
        session = packageInstaller.openSession(sessionId)

@fynngodau Can you take a look? This is quite urgent.

fynngodau · 2025-06-25T07:45:10Z

@DaVinci9196 I could not reproduce your problem, but I also do not have access to the SessionStorage class that you implemented. Hence I instead tried the following code (replacing lines 134–135 of Install.kt):

        sessionId = packageInstaller.createSession(params)
        session = packageInstaller.openSession(sessionId)
        packageInstaller.updateSessionAppLabel(sessionId, packageName)
        session.close()
        Log.d(TAG, "session closed")
        Log.d(TAG, packageInstaller.mySessions.joinToString(",") { sessionInfo -> sessionInfo.sessionId.toString() + " of package " + sessionInfo.appLabel })
        session = packageInstaller.openSession(sessionId)
        Log.d(TAG, "session reopened")

This worked without problems:

mySessions returned the currently pending session
I could access its metadata (this could be a good alternative to your SessionStorage implementation, as I would expect mySessions to always be in sync with whether the system has discarded the session due to timeout (after a day or so per docs))
I was able to reopen the session (but I did not try with closing and reopening the app)

Does the above code already produce a problem for you?

I noticed that you are never closing the session. I would suggest adding this to the finally block in your version of the code, maybe it helps.

DaVinci9196 · 2025-06-25T09:14:23Z

@DaVinci9196 I could not reproduce your problem, but I also do not have access to the SessionStorage class that you implemented. Hence I instead tried the following code (replacing lines 134–135 of Install.kt):
        sessionId = packageInstaller.createSession(params)
        session = packageInstaller.openSession(sessionId)
        packageInstaller.updateSessionAppLabel(sessionId, packageName)
        session.close()
        Log.d(TAG, "session closed")
        Log.d(TAG, packageInstaller.mySessions.joinToString(",") { sessionInfo -> sessionInfo.sessionId.toString() + " of package " + sessionInfo.appLabel })
        session = packageInstaller.openSession(sessionId)
        Log.d(TAG, "session reopened")
This worked without problems:

mySessions returned the currently pending session

I could access its metadata (this could be a good alternative to your SessionStorage implementation, as I would expect mySessions to always be in sync with whether the system has discarded the session due to timeout (after a day or so per docs))

I was able to reopen the session (but I did not try with closing and reopening the app)

Does the above code already produce a problem for you?

I noticed that you are never closing the session. I would suggest adding this to the finally block in your version of the code, maybe it helps.

This code cannot run on my phone and will report an error @fynngodau

DaVinci9196 · 2025-06-25T09:20:50Z

and
@fynngodau I see the following code in the Delivery.kt class. What will happen if these codes are not included?

pf=2&pf=3&pf=4&pf=5&pf=7&pf=8&pf=9&pf=10&da=4&bda=4&bf=4&fdcf=1&fdcf=2

I have found that &da=4 will cause problems when PayPal switches to voice. Can this be removed? @fynngodau

…esponses—for example, with PayPal.

mar-v-in · 2025-07-13T11:26:25Z

@DaVinci9196 I tried with just the code fragment from #2898 (comment) in a minimal demo app on multiple devices, including P60 Pro with EMUI 14 and Mate X5 with Harmony OS 4 and it worked as expected and reopened the session on all of them. What device did you use for this?

Looking at the code, I believe the issue might be a concurrency issue. Note that installPackagesInternal is a suspendable function and does not have any mutexes or anything preventing it from being invoked more than once. This means that a second call to installPackagesInternal will fail if it happens for the same package as one that is already ongoing.

DaVinci9196 · 2025-07-14T01:15:13Z

@DaVinci9196 I tried with just the code fragment from #2898 (comment) in a minimal demo app on multiple devices, including P60 Pro with EMUI 14 and Mate X5 with Harmony OS 4 and it worked as expected and reopened the session on all of them. What device did you use for this?

Looking at the code, I believe the issue might be a concurrency issue. Note that installPackagesInternal is a suspendable function and does not have any mutexes or anything preventing it from being invoked more than once. This means that a second call to installPackagesInternal will fail if it happens for the same package as one that is already ongoing.

I have modified it according to this comment #2898 (comment), you can test it with the latest code

mar-v-in

Some minor nits to be fixed.

vending-app/src/main/java/org/microg/vending/delivery/Delivery.kt

vending-app/src/main/kotlin/com/android/vending/installer/SessionResultReceiver.kt

vending-app/src/main/kotlin/com/android/vending/installer/Install.kt

...ing-app/src/main/kotlin/com/google/android/finsky/splitinstallservice/SplitInstallManager.kt

vending-app/src/main/kotlin/com/android/vending/installer/Install.kt

fynngodau

Thanks for the improvements to this PR so far. However, it does not fully work yet from my tests.

vending-app/src/main/kotlin/com/android/vending/installer/Install.kt

fynngodau · 2025-07-18T13:58:54Z

I have found that &da=4 will cause problems when PayPal switches to voice. Can this be removed?

My answer is: nobody really knows what these options mean. I see no regressions caused by removing it so I consider it ok.

quimodotcom · 2025-07-21T23:06:56Z

0.3.9 here we come!

mar-v-in · 2025-07-23T08:38:57Z

LGTM, Thanks @DaVinci9196 and @fynngodau for the work!

ale5000-git · 2025-07-23T09:30:20Z

vending-app/src/main/kotlin/com/android/vending/installer/Install.kt

+                    while (inputStream.read(buffer).also { bytesRead = it } != -1) {
+                        total += bytesRead
+                    }
+                    inputStream.close()


@mar-v-in
Wouldn't make sense to put inputStream.close() inside a finally block to be sure it is always closed even in case of unknown errors.

Fix split install issue

b498a0f

mar-v-in added the 📦 Asset Modules Asset Packs, Play Asset Delivery and related marketing terms label May 14, 2025

mar-v-in requested a review from fynngodau May 27, 2025 08:33

mar-v-in added this to the 0.3.9 milestone Jun 11, 2025

fynngodau suggested changes Jun 15, 2025

View reviewed changes

Adjust the code logic

fbca26a

DaVinci9196 added 2 commits June 30, 2025 16:07

Remove the hardcoded parameter, as it may cause issues with request r…

28e59a7

…esponses—for example, with PayPal.

Adjust the caching strategy.

c9b17b6

DaVinci9196 requested a review from fynngodau July 1, 2025 07:48

DaVinci9196 added 3 commits July 2, 2025 15:21

Remove unused code and adjust the notification logic.

3069678

Optimize the split install logic.

0304a30

Remove the notification in exceptional cases.

14a36fc

DaVinci9196 and others added 2 commits July 14, 2025 09:16

Merge branch 'master' into fix_split_install

0cacdd4

Optimizing the code

e2eb0c8

mar-v-in requested changes Jul 16, 2025

View reviewed changes

Optimizing the code

4eeab43

DaVinci9196 requested a review from mar-v-in July 16, 2025 13:06

fynngodau reviewed Jul 17, 2025

View reviewed changes

vending-app/src/main/kotlin/com/android/vending/installer/Install.kt Outdated Show resolved Hide resolved

Optimizing the code

7f73181

DaVinci9196 requested a review from fynngodau July 18, 2025 03:53

fynngodau suggested changes Jul 18, 2025

View reviewed changes

DaVinci9196 requested a review from fynngodau July 18, 2025 12:14

Optimizing the code

09f186b

fynngodau reviewed Jul 18, 2025

View reviewed changes

vending-app/src/main/kotlin/com/android/vending/installer/Install.kt Outdated Show resolved Hide resolved

Optimizing the code

9e485db

DaVinci9196 requested a review from fynngodau July 18, 2025 14:12

Log optimization

2123ead

Merge branch 'master' into fix_split_install

c732987

mar-v-in merged commit 4099b31 into microg:master Jul 23, 2025
1 check passed

ale5000-git reviewed Jul 23, 2025

View reviewed changes

DaVinci9196 deleted the fix_split_install branch July 24, 2025 02:47

Uh oh!

Fix split install issue #2898

Fix split install issue #2898

Uh oh!

Conversation

DaVinci9196 commented May 8, 2025

Uh oh!

fynngodau left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DaVinci9196 commented Jun 16, 2025

Uh oh!

fynngodau commented Jun 16, 2025

Uh oh!

DaVinci9196 commented Jun 16, 2025

Uh oh!

fynngodau commented Jun 16, 2025

Uh oh!

DaVinci9196 commented Jun 16, 2025

Uh oh!

DaVinci9196 commented Jun 16, 2025

Uh oh!

fynngodau commented Jun 16, 2025

Uh oh!

DaVinci9196 commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fynngodau commented Jun 17, 2025

Uh oh!

DaVinci9196 commented Jun 18, 2025

Uh oh!

DaVinci9196 commented Jun 24, 2025

Uh oh!

fynngodau commented Jun 25, 2025

Uh oh!

DaVinci9196 commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DaVinci9196 commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mar-v-in commented Jul 13, 2025

Uh oh!

DaVinci9196 commented Jul 14, 2025

Uh oh!

mar-v-in left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fynngodau left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fynngodau commented Jul 18, 2025

Uh oh!

quimodotcom commented Jul 21, 2025

Uh oh!

mar-v-in commented Jul 23, 2025

Uh oh!

Uh oh!

ale5000-git Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

DaVinci9196 commented Jun 17, 2025 •

edited

Loading

DaVinci9196 commented Jun 25, 2025 •

edited

Loading

DaVinci9196 commented Jun 25, 2025 •

edited

Loading