Skip to content

added FINOS APIs #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

added FINOS APIs #62

merged 1 commit into from
May 28, 2025

Conversation

vickybesra
Copy link
Contributor

Description

  • Added new APIs for FINOS
  • Added new package for FINOS APIs
  • Updated the description for each newly added FINOS APIs

Related issue(s)

See also #52

yada
yada requested changes May 27, 2025
View reviewed changes
Copy link
Member

@yada yada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the category (Banking will be fine, I think) metadata to put it in the correct area and keywords

artifacts/finos.org/trade-service/0.1.0/trade-service.0.1.0.api.yml Outdated
- email: laurent@microcks.io
name: Laurent Broudoux
keywords:
- camara
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong keywords, please update with something related to Finos, see open banking mocks.

artifacts/finos.org/trade-processor/1.0/trade-processor.1.0.api.yml
maintainers:
- email: laurent@microcks.io
name: Laurent Broudoux
keywords:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong keywords, please update with something related to Finos, see open banking mocks.

artifacts/finos.org/reference-data-service/1.0/reference-data-service.1.0.api.yml
maintainers:
- email: laurent@microcks.io
name: Laurent Broudoux
keywords:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong keywords, please update with something related to Finos, see open banking mocks.

artifacts/finos.org/position-service/0.1.0/position-service.0.1.0.api.yml
maintainers:
- email: laurent@microcks.io
name: Laurent Broudoux
keywords:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong keywords, please update with something related to Finos, see open banking mocks.

artifacts/finos.org/finos.org.package.yml Outdated
metadata:
name: finos.org
displayName: Finos APIs
categories: Telco
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong category

artifacts/finos.org/account-service/1.0/account-service.1.0.api.yml
maintainers:
- email: laurent@microcks.io
name: Laurent Broudoux
keywords:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong keywords, please update with something related to Finos, see open banking mocks.

@vickybesra
Copy link
Contributor Author

Thanks for the correction, I'll update it

@vickybesra
added FINOS APIs
e358954 
Signed-off-by: Vicky Besra <vickybesra2000@gmail.com>
@vickybesra vickybesra force-pushed the add-new-industry-APIs branch from f257f99 to e358954 Compare May 28, 2025 07:11
@vickybesra vickybesra requested a review from yada May 28, 2025 07:23
@vickybesra
Copy link
Contributor Author

@yada, PTAL I have updated the categories and keywords. Let me know if any further changes is required.

yada
yada approved these changes May 28, 2025
View reviewed changes
Copy link
Member

@yada yada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with thanks

@yada yada added the component/documentation Improvements or additions to documentation label May 28, 2025
@yada yada merged commit a4a9b31 into microcks:master May 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yada yada yada approved these changes

Assignees

No one assigned

Labels

component/documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vickybesra @yada