Skip to content

moshpit -> q2-moshpit #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025
Merged

moshpit -> q2-moshpit #48

merged 1 commit into from
Feb 25, 2025

Conversation

Oddant1
Copy link
Contributor

@Oddant1 Oddant1 commented Feb 24, 2025

@cdiener unfortunately, we recently changed the name of one of our environments for the coming release and I got the name wrong in the env file. Fortunately, I have a GitHub action to lint the environments. Unfortunately, it was not in place in time to catch the issue with this env. Fortunately, it is in place now!

Please do not merge this PR until qiime2/library-plugins#14 is passing ci. I will let you know here when that is.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.41%. Comparing base (f38647e) to head (0127048).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   90.41%   90.41%           
=======================================
  Files          11       11           
  Lines         334      334           
  Branches       13       13           
=======================================
  Hits          302      302           
  Misses         30       30           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Oddant1
Copy link
Contributor Author

Oddant1 commented Feb 24, 2025

Alright @cdiener the env files are now passing the linter, you can merge this whenever. I apologize for this hiccup while we finalize this workflow.

@cdiener cdiener merged commit 2970f8d into micom-dev:main Feb 25, 2025
9 checks passed
@Oddant1 Oddant1 deleted the fix-env-files branch February 25, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants