-
Notifications
You must be signed in to change notification settings - Fork 920
Updated onlyoffice index.go to respect url behind proxy #767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Updated onlyoffice index.go to respect url behind proxy #767
Conversation
The PR would break the default setup where the ONLY OFFICE setup come from this and is set to http://onlyoffice/, aka a URL that's not available to the frontend |
Can there be another alternative? |
Or another env variable for external URL that overrides |
That wouldn't be great from a end user point of view and that approach will stop working in the next few months. To understand why, we need to dig through how this plugin was done in the first place and why it was made the way it currently is. The general model of this plugin is to proxy the traffic to only office. This proxy approach was taken initially because:
yes, the best approach is to address the root cause of the issue which is a bug in here. |
8b0c5e5
to
023b018
Compare
d08482f
to
c3f2c57
Compare
73f9b79
to
acad39b
Compare
5368c95
to
8d89c78
Compare
745e55d
to
e7097b4
Compare
54c1682
to
8ce537f
Compare
af207c1
to
e72cbe3
Compare
b95fa04
to
11c4a74
Compare
9757ff1
to
7fa253f
Compare
5e9f59a
to
b9f2ee9
Compare
This change by JMarcosHP fixes OnlyOffice connection error when run behind nginx proxy manager, reference issue #766