Restore file download UI when OnlyOffice plugin is disabled #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, this may be tangentially related to issue #715, as my motivation for disabling OnlyOffice is that I've found it corrupts some documents on save, and that PR is another possible mitigation. |
|
You're right, it will take me a bit of time to test this out but I'll keep you up to date |
mickael-kerjean
force-pushed
the
master
branch
2 times, most recently
from
f077123 to
0ff9d62
Compare
mickael-kerjean
force-pushed
the
master
branch
from
53b12f9 to
96b566e
Compare
mickael-kerjean
force-pushed
the
master
branch
from
8b0c5e5 to
023b018
Compare
mickael-kerjean
force-pushed
the
master
branch
from
d08482f to
c3f2c57
Compare
mickael-kerjean
force-pushed
the
master
branch
2 times, most recently
from
73f9b79 to
acad39b
Compare
mickael-kerjean
force-pushed
the
master
branch
2 times, most recently
from
5368c95 to
8d89c78
Compare
mickael-kerjean
force-pushed
the
master
branch
4 times, most recently
from
745e55d to
e7097b4
Compare
mickael-kerjean
force-pushed
the
master
branch
10 times, most recently
from
54c1682 to
8ce537f
Compare
mickael-kerjean
force-pushed
the
master
branch
2 times, most recently
from
af207c1 to
e72cbe3
Compare
mickael-kerjean
force-pushed
the
master
branch
6 times, most recently
from
b95fa04 to
11c4a74
Compare
mickael-kerjean
force-pushed
the
master
branch
5 times, most recently
from
9757ff1 to
7fa253f
Compare
mickael-kerjean
force-pushed
the
master
branch
2 times, most recently
from
5e9f59a to
b9f2ee9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the OnlyOffice plugin statically registered mime types with
Hooks.Register.XDGOpenon initialization; however, this meant that if you disabled the plugin, those mime types would still remain associated with the plugin. In that case, any office document would return a blank page, since it would still attempt to open with the disabled OnlyOffice plugin handlers.This change adds a new
Hooks.Register.XDGOpenFunchook, so that code inxdg-open.jscan be evaluated dynamically. With it, mime type overrides can be returned only when the OnlyOffice plugin is enabled.While the private API for
xdg_opennow accepts an array of functions returning a string (similar to the CSS hook), the public API forHooks.Register.XDGOpenandHooks.Get.XDGOpenremains unchanged, so this shouldn't break any 3rd party plugins using it.Fixes issue #717.