Bug #382: Enhance davmail script to allow overrides #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be backwards compatible, but now you can pass in environmental variables (seen below) to override various default settings. Even better, if you just want to add java arguments (example: UI scaling) you can set JAVA_USER_OPTS and not have to worry about anything else. CLASSPATH EXTRA_CLASSPATH JAVA JAVA_CORE_OPTS JAVA_EXTRA2_OPTS JAVA_EXTRA_OPTS JAVA_NET_OPTS_DFL JAVA_OPTS JAVA_USER_OPTS JFX_CLASSPATH LD_LIBRARY_PATH SWT_GTK3
SethRobertson
changed the title
|
This is a good idea, @SethRobertson ! May I suggest running the script through shellcheck (see https://www.shellcheck.net/)? It's an excellent linter for shell scripts. For example, it suggests using
instead of
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be backwards compatible, but now you can pass in environmental variables (seen below) to override various default settings. Even better, if you just want to add java arguments (example: UI scaling) you can set JAVA_USER_OPTS and not have to worry about anything else.
Not fully tested since I don't have all of those environments.
CLASSPATH
EXTRA_CLASSPATH
JAVA
JAVA_CORE_OPTS
JAVA_EXTRA2_OPTS
JAVA_EXTRA_OPTS
JAVA_NET_OPTS_DFL
JAVA_OPTS
JAVA_USER_OPTS
JFX_CLASSPATH
LD_LIBRARY_PATH
SWT_GTK3