Skip to content

[lite_chain_01] Added an option to mirror the controller's behaviour between L and R sides #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,14 @@ def addObjects(self):

self.normal = self.guide.blades["blade"].z * -1
self.binormal = self.guide.blades["blade"].x

self.WIP = self.options["mode"]

rot_offset = [
self.settings["joint_rot_offset_x"],
self.settings["joint_rot_offset_y"],
self.settings["joint_rot_offset_z"],
]

if self.negate and self.settings["overrideNegate"]:
self.negate = False
self.n_factor = 1
Expand All @@ -41,30 +46,34 @@ def addObjects(self):
# FK controllers ------------------------------------
self.fk_npo = []
self.fk_ctl = []
t = self.guide.tra["root"]

parent = self.root
tOld = False
fk_ctl = None
previous_transform = None
self.previusTag = self.parentCtlTag
for i, t in enumerate(transform.getChainTransform(self.guide.apos,
self.normal,
self.negate)):
dist = vector.getDistance(self.guide.apos[i],
self.guide.apos[i + 1])
if self.settings["neutralpose"] or not tOld:

chain_pos = transform.getChainTransform(
self.guide.apos, self.normal, self.negate)

for i, t in enumerate(chain_pos):
if self.settings["neutralpose"] or not previous_transform:
tnpo = t
else:
tnpo = transform.setMatrixPosition(
tOld,
previous_transform,
transform.getPositionFromMatrix(t))

dist = vector.getDistance(self.guide.apos[i], self.guide.apos[i + 1])
if self.settings["mirrorBehaviour"] and self.negate:
dist = dist * -1
rot_offset = [180, 180, 0]
tnpo = transform.setMatrixScale(t, [-1, -1, -1])

fk_npo = primitive.addTransform(
parent, self.getName("fk%s_npo" % i), tnpo)
fk_ctl = self.addCtl(
fk_npo,
"fk%s_ctl" % i,
t,
tnpo,
self.color_fk,
"cube",
w=dist,
Expand All @@ -76,11 +85,19 @@ def addObjects(self):

self.fk_npo.append(fk_npo)
self.fk_ctl.append(fk_ctl)
tOld = t
self.previusTag = fk_ctl
previous_transform = t
parent = fk_ctl
if self.settings["addJoints"]:
self.jnt_pos.append([fk_ctl, i, None, False])
self.jnt_pos.append(
{
"obj": fk_ctl,
"name": i,
"newActiveJnt": None,
"UniScale": False,
"rot_off": rot_offset
}
)

# =====================================================
# ATTRIBUTES
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
AUTHOR = "Miquel Campos"
URL = "www.mcsgear.com"
EMAIL = ""
VERSION = [1, 1, 0]
VERSION = [1, 1, 1]
TYPE = "lite_chain_01"
NAME = "chain"
DESCRIPTION = "Super simple and light weight FK chain"
Expand Down Expand Up @@ -61,6 +61,7 @@ def addParameters(self):

self.pNeutralPose = self.addParam("neutralpose", "bool", True)
self.pOverrideNegate = self.addParam("overrideNegate", "bool", False)
self.pMirrorBehaviour = self.addParam("mirrorBehaviour", "bool", False)
self.pAddJoints = self.addParam("addJoints", "bool", True)
self.pUseIndex = self.addParam("useIndex", "bool", False)
self.pParentJointIndex = self.addParam(
Expand Down Expand Up @@ -122,6 +123,8 @@ def populate_componentControls(self):
"overrideNegate")
self.populateCheck(self.settingsTab.addJoints_checkBox,
"addJoints")
self.populateCheck(self.settingsTab.mirrorBehaviour_checkBox,
"mirrorBehaviour")

def create_componentLayout(self):

Expand All @@ -146,7 +149,12 @@ def create_componentConnections(self):
self.settingsTab.addJoints_checkBox.stateChanged.connect(
partial(self.updateCheck,
self.settingsTab.addJoints_checkBox,
"addJoints"))
"addJoints"))\

self.settingsTab.mirrorBehaviour_checkBox.stateChanged.connect(
partial(self.updateCheck,
self.settingsTab.mirrorBehaviour_checkBox,
"mirrorBehaviour"))

def dockCloseEventTriggered(self):
pyqt.deleteInstances(self, MayaQDockWidget)
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ def setupUi(self, Form):
self.overrideNegate_checkBox.setText("Override Negate Axis Direction For \"R\" Side")
self.overrideNegate_checkBox.setObjectName("overrideNegate_checkBox")
self.verticalLayout.addWidget(self.overrideNegate_checkBox)
self.mirrorBehaviour_checkBox = QtWidgets.QCheckBox(self.groupBox)
self.mirrorBehaviour_checkBox.setObjectName("mirrorBehaviour_checkBox")
self.mirrorBehaviour_checkBox.setText("Mirror Behaviour L and R")
self.verticalLayout.addWidget(self.mirrorBehaviour_checkBox)
self.addJoints_checkBox = QtWidgets.QCheckBox(self.groupBox)
self.addJoints_checkBox.setText("Add Joints")
self.addJoints_checkBox.setChecked(True)
Expand Down