Skip to content

fix: now pick_file can run on windows #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jinzhongjia
Copy link

@jinzhongjia jinzhongjia commented Mar 30, 2025

In the past, functions used Unix's check permissions to find executable files, which did not work on Windows.

Now change to use the suffix name and allow fallback to using powershell

new feat: when adapter.options.initialize_timeout_sec is false, dap will not notify use adapter is slow, this is very useful on large projects

@jinzhongjia jinzhongjia marked this pull request as draft March 30, 2025 10:39
@jinzhongjia
Copy link
Author

Sorry, there is a problem, I need to make some changes

@jinzhongjia jinzhongjia marked this pull request as ready for review March 30, 2025 10:47
@jinzhongjia
Copy link
Author

I made a little formatting in the code, so there may be a little more places to modify commit. If you think my formatting style is not good, you can pull it into the local format and then push it up.

@jinzhongjia
Copy link
Author

And I add a little feat:
when adapter.options.initialize_timeout_sec is false, dap will not notify use adapter is slow, this is very useful on large projects
The company I work in is about 15 seconds to compile the go project. This slow prompt is sometimes a headache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant