fix: lossy truncation in checked Instant arithmetic
#110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes and tests metrics-rs#109. Signed-off-by: Nissa <and-nissa@protonmail.com>
Signed-off-by: Nissa <and-nissa@protonmail.com>
tobz
reviewed
Dec 29, 2024
The main thing we care about here is that the Duration is not truncated. Signed-off-by: Nissa <and-nissa@protonmail.com>
tobz
approved these changes
Dec 29, 2024
|
Looks like merging is blocked on a test runner for WASM. I don't have experience with WASM infrastructure so its not clear to me where in Rust the issue is. |
|
Hmm, weird. I'll try and take a look at this today or tomorrow. |
|
Gah, the WASM stuff is so finicky. Since it seems pretty obvious that it's not relevant to ensure that the WASM tests pass for this change, I'm going to merge as-is. |
|
Will cut a release shortly. |
|
Released as Thanks again for your contribution! |
|
Thanks! Happy to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and tests #109.
Unresolved Questions
The test case currently asserts that offsets ofRemoved as of caae5341 << 64nanos always overflow, which relies onInstants being implemented as 64-bit nanosecond counts. It would be correct just to check that theInstantis not left unchanged, so should I remove those last two assertions?