PICARD-3127: feat(configurablecolumnsheader): Don't auto-close the menu when picking columns #2745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… column management - Introduced helper methods to create checkbox actions and manage column visibility in the context menu, improving code organization and readability. - Added dynamic state updates for column visibility, restore defaults, and lock actions, enhancing user experience. - Implemented a callback mechanism to synchronize UI elements based on the lock state, ensuring consistent behavior in the context menu.
zas
requested changes
Oct 13, 2025
…ction creation - Enhanced readability by formatting parameters in the checkbox action creation method, ensuring clearer code structure.
zas
reviewed
Oct 14, 2025
| restore_action = self._add_restore_action(menu) | ||
| lock_checkbox = self._add_lock_action(menu) | ||
| menu.addSeparator() | ||
| manage_action = self._add_manage_action(menu) |
There was a problem hiding this comment.
I think we should re-order those to:
menu.addSeparator()
restore_action = self._add_restore_action(menu)
manage_action = self._add_manage_action(menu)
menu.addSeparator()
lock_checkbox = self._add_lock_action(menu)
Also we should be consistent regarding sentence case vs title case in menus (see https://tickets.metabrainz.org/browse/PICARD-562)
This looks better to me:
There was a problem hiding this comment.
Also we should be consistent regarding sentence case vs title case in menus
Agree 100%. I prefer the second image as well.
There was a problem hiding this comment.
No opinion, really. Agreed on the caps consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Currently, when users right-click on column headers and toggle column visibility, the context menu closes after each selection. This forces users to repeatedly open the menu to show/hide multiple columns, resulting in poor UX.
Solution
Applied the same
QWidgetAction+QCheckBoxpattern from PICARD-3114 to the columns picker menu inconfigurablecolumnsheader.py:QActionitems withQWidgetActioncontaining embeddedQCheckBoxwidgetscontextMenuEventfollowing SOLID principles for improved maintainabilityThe menu now stays open while users toggle multiple columns, and the lock state dynamically controls the enabled state of all dependent actions.
Action
Additional actions required: