PICARD-3114: fix(mainwindow): enhance profile selection menu with checkboxes #2743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced QAction with QWidgetAction containing QCheckBox for profile selection, allowing toggling without closing the menu. - Added a new method to set the enabled state of profiles and refresh the UI accordingly, improving user interaction and experience.
zas
reviewed
Oct 12, 2025
- Deleted the _update_profile_selection method, which toggled the enabled state of profiles, as it is no longer needed following recent enhancements to the profile selection menu. - This cleanup improves code maintainability and reduces complexity in the MainWindow class.
zas
approved these changes
Oct 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a…
Describe this change in 1-2 sentences:
QWidgetAction+QCheckBox, and add_set_profile_enabledto update state and UI deterministically.Problem
PICARD-3114(link).Solution
QWidgetAction+QCheckBoxso toggling does not close the menu.MainWindow._set_profile_enabled(profile_id: str, enabled: bool)to set state and call_reset_option_menu_state()to refresh dependent UI.Action
Additional actions required: