fix: cached value and cached sorting issues #2737
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix stale custom column values and incompatible sort keys by adding targeted cache invalidation and safe re-sorting.
Problem
Custom column values remained stale after tag changes.
Editing sort order could leave incompatible sort keys cached, causing incorrect sorting.
JIRA ticket (optional): PICARD-XXX
Solution
CacheInvalidatable
protocol; implementinvalidate()
inChainedValueProvider
andCachedSortAdapter
.CustomColumn.invalidate_cache()
and invoke it per-item inTreeItem.update_colums_text
._sortkeys
, refresh data, and trigger resort (BaseTreeView
).try...except...pass
with explicit handling orcontextlib.suppress
per project guidelines.Action
Additional actions required: