Skip to content

Conversation

rdswift
Copy link
Collaborator

@rdswift rdswift commented Sep 5, 2025

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

There was inconsistent use of Qt standard buttons and Picard version of standard buttons, and "Make It So!" was being used in multiple places when the original intent was to use it on the Options page only.

  • JIRA ticket (optional): PICARD-XXX

Solution

Remove the Picard standard buttons class and use Qt.QButtonBox.StandardButton definitions throughout. Replace additional use of "Make It So!" buttons with standard "Ok" button.

Action

Additional actions required:

  • Update Picard documentation (please include a reference to this PR)
  • Other (please specify below)

@rdswift rdswift added this to the 3.0 milestone Sep 5, 2025
@rdswift rdswift requested review from phw and zas September 5, 2025 18:46
@rdswift rdswift force-pushed the standardize_buttons branch from 5c4f028 to 76a2bea Compare September 5, 2025 19:15
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a good move, thanks for this change

Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zas zas merged commit 95f5e5b into metabrainz:master Sep 8, 2025
45 checks passed
@rdswift rdswift deleted the standardize_buttons branch September 8, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants