Skip to content

Conversation

Oleghishak
Copy link
Contributor

Updated the Ukrainian translation file (po/uk.po).
Added missing strings and improved existing translations.

Updated the Ukrainian translation for Picard. Added the updated picard.po file in a separate branch.
@Oleghishak Oleghishak closed this Aug 26, 2025
@phw
Copy link
Member

phw commented Aug 26, 2025

@Oleghishak Thanks for the contribution. Any specific reason you closed this PR?

Generally our preferred way of translating is to have the translations directly updated on https://translations.metabrainz.org/projects/picard/ . But we can also do it via direct merge request here, no problem with that. I think especially for a language that currently has less translation activity this works well.

@Oleghishak
Copy link
Contributor Author

I translated and updated many strings in Poedit, including outdated ones. However, the process of merging or uploading translations via GitHub and Weblate turned out to be quite complicated for me. Since the pull request was blocked and required an additional reviewer, it became tiring and frustrating. In the past, I just translated and sent the file by email, and that was easy for me. I understand this is progress and now it is easier for you.

@Oleghishak Oleghishak reopened this Aug 27, 2025
@Oleghishak
Copy link
Contributor Author

Oleghishak commented Aug 27, 2025 via email

@Oleghishak
Copy link
Contributor Author

uk.zip

@phw
Copy link
Member

phw commented Aug 27, 2025

Thanks again for this translation, much appreciated. That the Ukrainian translation was so incomplete was bugging me for a while already.

For your information, there had been an editor who did partly do the Ukrainian translation with machine translation despite not speaking Ukrainian himself. See discussion on https://community.metabrainz.org/t/weblate-and-ukrainian-language/714278/15 . It was fortunately stopped, but if you encountered some odd strings it was probably because of this.

File with translation below. I did not touch lines like these:
"$foreach(name,code,separator=\"; \")\n"
"\n"
"Iterates over each element found in the multi-value tag name, [...]

Yes, those are the function documentation. Those are a bit of a pain to translate, really. I did them last for the German translation. Ideally the English description below the first line should be translated. The scripting line at the start ("$foreach(name,code,separator="; ")") and scripting examples are often kept as they are. It is ok to give the parameter names (here "name", "code" and "separator") a translation, though. I know for some languages the translators chose to do so, for others not. E.g. for the Dutch translation the translator chose to translate the placeholder names.

But if you don't feel comfortable with translating those strings I can sympathize ;)

However, the process of merging or uploading translations via GitHub and Weblate turned out to be quite complicated for me. Since the pull request was blocked and required an additional reviewer, it became tiring and frustrating.

I'm sorry for that. But you need to give us some time with the pull requests.

Uploading the translated po file in Weblate is also possible. If you are on the Ukrainian translation page at https://translations.metabrainz.org/projects/picard/3/app/uk/ there should be a menu entry Files > Upload translation, where you can upload the file translated in poedit (at least I hope it is there for all users):

image

@phw phw merged commit d5745a0 into metabrainz:master Aug 27, 2025
60 of 69 checks passed
@rdswift
Copy link
Collaborator

rdswift commented Aug 27, 2025

at least I hope it is there for all users

It isn't. Even I don't have upload rights to the picard docs project. It looks like everybody may have access to download, but not upload (which really doesn't make much sense to me).

@Oleghishak
Copy link
Contributor Author

"'Upload' in the 'File' menu is missing in my Weblate."

Screenshot_20250827-204322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants