Skip to content

Force profiles options page to always save first #2715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2025
Merged

Force profiles options page to always save first #2715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion picard/ui/options/dialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,13 @@ def accept(self):
self._show_page_error(page, e)
return

for page in sorted(self.loaded_pages, key=lambda p: (p.SORT_ORDER, p.NAME)):
# Force the `profiles` page to always save first to avoid an error when
# saving settings to a new profile that has been marked as enabled.
pages = [
self.get_page('profiles'),
]
pages.extend(x for x in sorted(self.loaded_pages, key=lambda p: (p.SORT_ORDER, p.NAME)) if x.NAME != 'profiles')
for page in pages:
try:
page.save()
except Exception as e:
Expand Down
4 changes: 1 addition & 3 deletions picard/ui/options/profiles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,7 @@ class ProfilesOptionsPage(OptionsPage):
NAME = 'profiles'
TITLE = N_("Option Profiles")
PARENT = None
# Set SORT_ORDER to negative number to ensure the profiles page is saved first to avoid
# an error when saving settings to a new profile that has been marked as enabled.
SORT_ORDER = -100
SORT_ORDER = 10
ACTIVE = True
HELP_URL = "/config/options_profiles.html"

Expand Down
Loading