Change platform specific deps #2707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uv expects the requirement groups not to conflict. Which generally is fine, but does not fit the use case of the platform specific requirements files as used by Picard builds.
zas
approved these changes
Aug 16, 2025
|
Maybe we can even get rid of it. Right now in this setup we actually don't need it (same deps anywhere), but I'm yet hesitant to change it. Just a few months ago we had the need for different Qt6 versions on Win and macOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The management of requirements-win.txt and requirements-macos-11.0.txt was moved to uv as separate requirements groups. Unfortunately this doesn't fit our use case. uv expects the groups to not conflict. So you cannot for example fix a requirement in one group without fixing it for the entire project. Also setting conflicting versions in different groups is not allowed.
Solution
Revert to handling the requirements-win.txt and requirements-macos-11.0.txt manually again. For the majority of use cases we want to use the general requirments in pyproject.toml anyway, and I'll usually just upgrade the platform specific ones to the latest versions we also use in the generated requirements.txt. I'm fine to manage the specific cases for the wind and mac binary builds manually when needed.