PICARD-3084: Allow up to 3 char replacement in illegal chars #2705
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
QLineEdit
fields were restricted to length 1, and the validator rejected spaces.Solution
maxLength
to 3 for all replacement fields inui/win_compat_dialog.ui
and adjust field width for visibility.WinCompatReplacementValidator
inpicard/ui/options/renaming_compat.py
to allow multi-character strings and whitespace while still forbidding Windows-illegal characters and directory separators.test/test_win_compat_replacement_validator.py
:OldValidator
.(text, pos)
.Notes:
replace_win32_incompat
) remains unchanged; it already supports string mappings.Action
Additional actions required:
picard-docs
) to note that Windows-illegal character replacements now accept up to 3 characters (including spaces), and clarify per-character mapping behavior.