-
-
Notifications
You must be signed in to change notification settings - Fork 419
PICARD-3085: Add more details to album art info box and tests #2701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PICARD-3085: Add more details to album art info box and tests #2701
Conversation
More image details make sense. My problem with this is the vertical size this display uses. It's the one reason why I had been hesitant on adding any additional info below the images. We already sometimes have complaints of the metadatabox height being too large. We had this pane collapsible in the past, which was bad because people lost it completely and did not figure out how to recover it. Suggested was also to make the cover art area scrollable, but I think that's horrible UI. Things I think could work:
|
@phw, I echo your concerns.
If we're going to offer this, I think it should be optional for the user. My thinking is Option 2, with Option 1 if deemed necessary. A possible 4th option would be to superimpose the information on the image itself, but that brings with it a whole new set of potential issues. |
0da25cd
to
f0dcdd9
Compare
I agree completely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @zas . The configuration should go to a Cover Art Box page below the User Interface settings. Apart from that the PR looks good to me. I just have a question / comment on the initialize_covertartbox_settings
function.
48c6413
to
bbcf543
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Display cover art details (type, size in kB/KiB, dimensions, mime) directly in the cover art view below thumbnails and on hover, showing info for the first (front) image.
Problem
Users must open “Show more details” to see image size/dimensions/mime, which slows bulk artwork review.
Solution
CoverArtBox
to render a four-line detail block for the first image:{type}
,{size kB} ({size KiB})
,{W} x {H}
,{mime}
Action
Additional actions required: