Skip to content

Conversation

knguyen1
Copy link
Contributor

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:
    Display cover art details (type, size in kB/KiB, dimensions, mime) directly in the cover art view below thumbnails and on hover, showing info for the first (front) image.

Problem

Users must open “Show more details” to see image size/dimensions/mime, which slows bulk artwork review.

Solution

  • Update CoverArtBox to render a four-line detail block for the first image:
    • {type}, {size kB} ({size KiB}), {W} x {H}, {mime}
  • Show the same details as tooltip on hover.
  • Support both current (new) and original thumbnails; headers shown when both are present and differ.
  • Add concise unit tests for formatting and label/tooltip updates; tests are xdist-safe.
image

Action

Additional actions required:

  • Update Picard documentation (please include a reference to this PR)
  • Other (please specify below)

@phw
Copy link
Member

phw commented Aug 12, 2025

More image details make sense. My problem with this is the vertical size this display uses. It's the one reason why I had been hesitant on adding any additional info below the images.

We already sometimes have complaints of the metadatabox height being too large. We had this pane collapsible in the past, which was bad because people lost it completely and did not figure out how to recover it. Suggested was also to make the cover art area scrollable, but I think that's horrible UI.

Things I think could work:

  1. Making display of those additional details an option, so it can be disabled to get more vertical space.
  2. Showing the image details in the tooltip. This could be done in addition to 1. also
  3. Showing the images side by side. This would also match how other new/old metadata is shown. But it takes more space horizontally then.

@rdswift
Copy link
Collaborator

rdswift commented Aug 12, 2025

@phw, I echo your concerns.

Things I think could work:

  1. Making display of those additional details an option, so it can be disabled to get more vertical space.
  2. Showing the image details in the tooltip. This could be done in addition to 1. also
  3. Showing the images side by side. This would also match how other new/old metadata is shown. But it takes more space horizontally then.

If we're going to offer this, I think it should be optional for the user. My thinking is Option 2, with Option 1 if deemed necessary.

A possible 4th option would be to superimpose the information on the image itself, but that brings with it a whole new set of potential issues.

@knguyen1
Copy link
Contributor Author

These options are available.

image image

@knguyen1 knguyen1 force-pushed the feat/picard-3085/show-coverart-filesize-and-dimensions branch from 0da25cd to f0dcdd9 Compare August 13, 2025 23:08
@zas
Copy link
Collaborator

zas commented Aug 15, 2025

These options are available.
image image

I would move those options to User Interface > Cover Art Box instead of having those under Cover Art (the pane is already pretty stuffed), after all that's UI-related options.

@phw @rdswift @knguyen1 What do you think?

@rdswift
Copy link
Collaborator

rdswift commented Aug 15, 2025

I would move those options to User Interface > Cover Art Box instead of having those under Cover Art (the pane is already pretty stuffed), after all that's UI-related options.

I agree completely.

Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @zas . The configuration should go to a Cover Art Box page below the User Interface settings. Apart from that the PR looks good to me. I just have a question / comment on the initialize_covertartbox_settings function.

@knguyen1
Copy link
Contributor Author

knguyen1 commented Aug 16, 2025

@zas @phw

  • Remove cover art config: ec3d155
  • Add cover art interface config: aefb6b4

@knguyen1 knguyen1 force-pushed the feat/picard-3085/show-coverart-filesize-and-dimensions branch from 48c6413 to bbcf543 Compare August 16, 2025 10:05
@phw phw added the Feature label Aug 16, 2025
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phw phw merged commit 6159da8 into metabrainz:master Aug 16, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants